<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129210/">https://git.reviewboard.kde.org/r/129210/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">mostly janitorial patch: port every terminal output to appropriate QCdebug/QCwarning, each different binary has its own logging category now, so it's possible to enable/disable them selectively.
this should also make plasmashell a bit more quiet on terminal by default</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">builds, still works</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(d6ed24d)</span></li>
<li>autotests/sortfiltermodeltest.cpp <span style="color: grey">(da0e393)</span></li>
<li>src/declarativeimports/calendar/CMakeLists.txt <span style="color: grey">(93d9c14)</span></li>
<li>src/declarativeimports/calendar/calendar.cpp <span style="color: grey">(790833b)</span></li>
<li>src/declarativeimports/calendar/eventpluginsmanager.cpp <span style="color: grey">(bcc6177)</span></li>
<li>src/declarativeimports/core/CMakeLists.txt <span style="color: grey">(689a4b6)</span></li>
<li>src/declarativeimports/core/datamodel.cpp <span style="color: grey">(06b64e4)</span></li>
<li>src/declarativeimports/core/datasource.cpp <span style="color: grey">(f60e2cc)</span></li>
<li>src/declarativeimports/core/framesvgitem.cpp <span style="color: grey">(bc8d45a6)</span></li>
<li>src/declarativeimports/core/iconitem.cpp <span style="color: grey">(8f29ee2)</span></li>
<li>src/declarativeimports/core/windowthumbnail.cpp <span style="color: grey">(0453c09)</span></li>
<li>src/declarativeimports/plasmacomponents/CMakeLists.txt <span style="color: grey">(8e5ca90)</span></li>
<li>src/declarativeimports/plasmacomponents/fullscreenwindow.cpp <span style="color: grey">(05da708)</span></li>
<li>src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp <span style="color: grey">(83016c2)</span></li>
<li>src/declarativeimports/plasmacomponents/qmenu.cpp <span style="color: grey">(c6b59a8)</span></li>
<li>src/declarativeimports/platformcomponents/CMakeLists.txt <span style="color: grey">(4cce385)</span></li>
<li>src/declarativeimports/platformcomponents/application.cpp <span style="color: grey">(1326a7b)</span></li>
<li>src/plasmapkg/CMakeLists.txt <span style="color: grey">(7d3df5d)</span></li>
<li>src/plasmapkg/plasmapkg.cpp <span style="color: grey">(3724ae8)</span></li>
<li>src/plasmaquick/CMakeLists.txt <span style="color: grey">(8aaa77a)</span></li>
<li>src/plasmaquick/configmodel.cpp <span style="color: grey">(03beac7)</span></li>
<li>src/plasmaquick/configview.cpp <span style="color: grey">(e8627c9)</span></li>
<li>src/plasmaquick/containmentview.cpp <span style="color: grey">(309a2cb)</span></li>
<li>src/plasmaquick/dialog.cpp <span style="color: grey">(9afdf60)</span></li>
<li>src/plasmaquick/dialogshadows.cpp <span style="color: grey">(10b5ed9)</span></li>
<li>src/plasmaquick/packageurlinterceptor.cpp <span style="color: grey">(4aa5c3a)</span></li>
<li>src/plasmaquick/view.cpp <span style="color: grey">(ca6ae6f)</span></li>
<li>src/scriptengines/qml/CMakeLists.txt <span style="color: grey">(fd953d6)</span></li>
<li>src/scriptengines/qml/plasmoid/containmentinterface.cpp <span style="color: grey">(d0dbda9)</span></li>
<li>src/scriptengines/qml/plasmoid/wallpaperinterface.cpp <span style="color: grey">(9ef2d03)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129210/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>