<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128437/">https://git.reviewboard.kde.org/r/128437/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Marco Martin</p>
<br />
<p>On September 28th, 2016, 10:36 a.m. UTC, Harald Sitter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated Sept. 28, 2016, 10:36 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcrash
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">with the rise of useful core dump handlers such as systemd's coredump and
ubuntu's apport it is no longer useful to handle things exclusively in
drkonqi. it bypasses sysadmins as well as distros in debugging efforts,
putting the entire flow of information on us.
the new behavior instead checks if a core pattern executable is set and if
so re-raises the signal so the kernel jumps in and invokes the handler.
(this unfortunately means that the core will contain our kcrash frames,
but that seems hardly avoidable)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">builds and passes</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(21ccd1df72f6ab2e60bb3f8f9212359f1c24c53f)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(e442520269835df71968bf7818aa34bd8bd945cf)</span></li>
<li>autotests/core_patterns/exec <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/core_patterns/no-exec <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/coreconfigtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(e733be69c6ca6e6c1a0608c8910cf4a9b52ffcc9)</span></li>
<li>src/config-kcrash.h.cmake <span style="color: grey">(f1b3a9babda3e2220aed3c19b735f90eb1ea8e7e)</span></li>
<li>src/coreconfig.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/coreconfig_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kcrash.cpp <span style="color: grey">(d9acb591edb2232db6c9e0dc2726cf0f189823a0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128437/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>