<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129042/">https://git.reviewboard.kde.org/r/129042/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 27th, 2016, 2:41 p.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 definitely a step forward.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">FWIW, testing it, seems to work fine.</p></pre>
<br />
<p>- Aleix</p>
<br />
<p>On September 27th, 2016, 2:07 p.m. CEST, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Sept. 27, 2016, 2:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
networkmanager-qt
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Uses "GetAll" method from o.f.DBus.Properties interface to get all properties at once, instead of initializing them one by one, which should significantly reduce number of blocking calls. Initialy I wanted to make this call asynchronous as well, but delayed initialization causes problems across the library so this is the easiest way how to do this.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/accesspoint.cpp <span style="color: grey">(60a284b)</span></li>
<li>src/activeconnection.cpp <span style="color: grey">(1b66fc5)</span></li>
<li>src/activeconnection_p.h <span style="color: grey">(60697e6)</span></li>
<li>src/adsldevice.cpp <span style="color: grey">(8f9bbff)</span></li>
<li>src/bluetoothdevice.cpp <span style="color: grey">(eb839e0)</span></li>
<li>src/bonddevice.cpp <span style="color: grey">(6d1899f)</span></li>
<li>src/bridgedevice.cpp <span style="color: grey">(3c347af)</span></li>
<li>src/device.cpp <span style="color: grey">(57538eb)</span></li>
<li>src/genericdevice.cpp <span style="color: grey">(8f26617)</span></li>
<li>src/gredevice.cpp <span style="color: grey">(c1a59c5)</span></li>
<li>src/infinibanddevice.cpp <span style="color: grey">(9bfa76f)</span></li>
<li>src/macvlandevice.cpp <span style="color: grey">(9b3c75f)</span></li>
<li>src/manager.cpp <span style="color: grey">(d2f706e)</span></li>
<li>src/manager_p.h <span style="color: grey">(50c3c34)</span></li>
<li>src/modemdevice.cpp <span style="color: grey">(4bb4a23)</span></li>
<li>src/olpcmeshdevice.cpp <span style="color: grey">(6f1212d)</span></li>
<li>src/settings.cpp <span style="color: grey">(90e7267)</span></li>
<li>src/teamdevice.cpp <span style="color: grey">(d07b145)</span></li>
<li>src/tundevice.cpp <span style="color: grey">(2a73012)</span></li>
<li>src/vethdevice.cpp <span style="color: grey">(77b48b4)</span></li>
<li>src/vlandevice.cpp <span style="color: grey">(fdfa297)</span></li>
<li>src/vpnconnection.cpp <span style="color: grey">(5dee6fc)</span></li>
<li>src/vpnconnection_p.h <span style="color: grey">(a8195ad)</span></li>
<li>src/wimaxdevice.cpp <span style="color: grey">(6118f2f)</span></li>
<li>src/wireddevice.cpp <span style="color: grey">(66bb649)</span></li>
<li>src/wirelessdevice.cpp <span style="color: grey">(3f2972b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129042/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>