<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128968/">https://git.reviewboard.kde.org/r/128968/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 21st, 2016, 12:38 nachm. CEST, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Would it make more sense to change meinproc5 to work like checkXML5 if invoked with that name (hardlink, copy, etc, a-la busybox)?</p></pre>
</blockquote>
<p>On September 21st, 2016, 3:33 nachm. CEST, <b>Ralf Habacker</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry, I do not know the reasons why this tool has been created and has not been integrated into meinproc5. You should ask the original author.</p></pre>
</blockquote>
<p>On September 21st, 2016, 3:45 nachm. CEST, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The original author (Laurent Montel, https://websvn.kde.org/?view=revision&revision=505145) don't remember much, and I guess it's not relevant here. My question was: from a multiplatform prospective, would this solution have any drawback? Where "this solution" is: have a checkXML5(.exe) executable which is an hardlink (or a copy, I guess, on Windows) to meinproc5, but exposing the behavior of the wrapper script?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Pro's:
- no additional source/cmake target/binary to maintain </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Neg's:
- increase the complexibility of meinproc5 caused by the need to support of additional 'checkXML5' use case
- more efforts required to maintain the related man pages caused by the dualism e.g. 'Do I need to update "meinproc5" or "checkXML5" man page
- duplicated executable on windows caused by pysical copy (hardlinks are not supported by cmake as far as I know)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seeing this I would stay with the checkXML5 executable introduced with this request.</p></pre>
<br />
<p>- Ralf</p>
<br />
<p>On September 21st, 2016, 11:35 vorm. CEST, Ralf Habacker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Documentation, KDE Frameworks and Luigi Toscano.</div>
<div>By Ralf Habacker.</div>
<p style="color: grey;"><i>Updated Sept. 21, 2016, 11:35 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Convert checkxml5 into a qt executable for cross plattform support.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">compiled at https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(8674faaba6346156907aa5fbbea1ee2b38865eda)</span></li>
<li>checkXML5.in.cmake <span style="color: grey">(d7a57c78ec768a4eb9d3c669b8fe3bbef2991c93)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(6f903b542bc9ba256dd379275567d5ff2127fe39)</span></li>
<li>src/checkXML5.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128968/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>