<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128680/">https://git.reviewboard.kde.org/r/128680/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 4th, 2016, 4:34 a.m. CEST, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Andreas, any idea which icon the action could use?</p></pre>
</blockquote>
<p>On September 10th, 2016, 3:01 p.m. CEST, <b>Andreas Kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would use visibility and hint to show/hide the font's that are not available in the selected font. will the font change to "not selected" grayed out when you show all characters also the ones that aren't available?</p></pre>
</blockquote>
<p>On September 12th, 2016, 11:30 p.m. CEST, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"visibility" and "hint" is the same icon, but one of them crossed-out. If I use both of them, it is confusing, because the tool button itself has a selected state (sunken frame and selected background).
So I see two options:
1) use the "hint" icon, and make the button unselected by default. Selecting it, the unavailable characters are then grayed out.
2) use the "visibility" icon, and make the button selected by default.
Unselecting it, the unavailable characters are then grayed out.
Which would you prefer? The code currently uses the unselected button for the default (do not gray-out unavailable characters) but I can reverse it.
Regarding your question, I have difficulties to parse it. Let me try to answer from what I understood: If font-merging is enabled, but none of the installed fonts have glyphs for a specific character, then this character is rendered as an rectangle box. The character cell is not disabled, so you will be able to select the character (e.g. to copy/paste it), even if you have no font with this character.</pre>
</blockquote>
<p>On September 13th, 2016, 8:02 a.m. CEST, <b>Heiko Tietze</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Third option is to have a less obtrusive visualization (going back to your first proposal) that makes the toggle button obsolete. But I have no idea how to do so since graying out is the opposite of unobtrusive. It depends heavily on the workflow meaning whether or not users should be able to deal with those characters at all.</p></pre>
</blockquote>
<p>On September 13th, 2016, 2:48 p.m. CEST, <b>Andreas Kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">personally I wouldn't grayed out by default cause I want to have this symbol and I don't care if this is available or not.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">on the other hand I think your app is really nice and usefull but you need some time to understand the different drop downs, ... so I didn't know your initial proposal. I will update some mockup where there is written all fonts and if someone select a font (arial) you see the not available chars grayed out as in your app.</p></pre>
</blockquote>
<p>On September 13th, 2016, 2:49 p.m. CEST, <b>Andreas Kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/kcharselect.png</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If font merging is enabled, Qt must know which font you prefer, because the replacement fonts are selected to be as similar as possible to the requested font. In other words, simply having an "All Fonts" choice does not allow the user to chose the base font.
I checked your proposal, and indeed having a separate list of scripts is on my TODO list, but this is orthogonal to this feature request.</pre>
<br />
<p>- Christoph</p>
<br />
<p>On September 1st, 2016, 6:45 p.m. CEST, Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, KDE Usability and Andreas Kainz.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated Sept. 1, 2016, 6:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=97420">97420</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Adds a toolbutton to the right of the font combobox to control the "font merging" property of QFont. When selected, characters which are not available in the font are disabled.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seeking feedback about:
- placement of the button
- used icon (currently "format-text-strikethrough"; it shows an S character which could stand for "substitution")
- action name and tooltip (see line 477 and 479)
- and code changes ;)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I was unsure if the toolbutton could have a popup menu showing three options:
1) show characters from all fonts
2) disable characters not available in font
3) hide characters not available in font</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">but I did not implement it, because it felt odd not being able to see <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">which</em> characters are not available in the font.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kcharselect.cpp <span style="color: grey">(30ddd34)</span></li>
<li>src/kcharselect_p.h <span style="color: grey">(db0259c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128680/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/7220dddb-ca1b-42a2-966c-791925156baf__snapshot1.png">Character table with font substitution (default)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/67c02866-b12c-4080-b6a4-22e29006448b__snapshot2.png">Character table with dimming substituted characters</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>