<div dir="ltr"><div style="font-family:monospace,monospace;font-size:small" class="gmail_default"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On 12 September 2016 at 09:10, Jaroslaw Staniek <span dir="ltr"><<a target="_blank" href="mailto:staniek@kde.org">staniek@kde.org</a>></span> wrote:<br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><div dir="ltr"><div style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_extra"><br><div class="gmail_quote"><span class="gmail-">On 12 September 2016 at 08:04, Kevin Funk <span dir="ltr"><<a target="_blank" href="mailto:kfunk@kde.org">kfunk@kde.org</a>></span> wrote:<br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><span>On Sunday, 11 September 2016 03:21:21 CEST Dominik Haumann wrote:<br>
> Hi all,<br>
><br>
> I just saw a commit by Volker turning nullptr into Q_NULLPTR with the<br>
> comment that Visual Studio 2012 does not support nullptr.<br>
><br>
> While this change is trivial for obvious reasons, do we really need to do<br>
> that?<br>
<br>
</span>I don't think so.<br>
<br>
nullptr is actually supported since VS2010 [1].<br>
<br>
Some other remark: I think noone's using anything below VS2015 for testing KDE<br>
on Windows anyway. I'm expecting compilation to be broken on earlier versions<br>
of VS.<br></blockquote></span><div><br><div style="font-family:monospace,monospace;font-size:small">I am not only testing but also using/depend on 2013, which has quite some C++11 features already. The builds of KF5 just work (this is not a CI, this is building from time to time). Sometimes patching is needed here and there because of completely unnecessary - for my context - dependency of kdoctools. Things improved here in 2016 anyway.<br><br></div><div style="font-family:monospace,monospace;font-size:small">If not for other reasons, please note that people may depend on < 2015 because some other component is not supported on 2015 or because od the boss'/customer's request.<br></div><div style="font-family:monospace,monospace;font-size:small"><br></div><div style="font-family:monospace,monospace;font-size:small">I think fixing on a 'beeding edge' compiler may be not the best strategy, yet I see no reason to be much less flexible in this regard than Qt is.<br></div></div></div></div></div></blockquote><div><br><div style="font-family:monospace,monospace;font-size:small;display:inline" class="gmail_default">That said, I'd be OK to set coding standard to use nullptr and override keywords directly without macros as these are both supported since 2012.<br></div><br></div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div style="font-family:monospace,monospace;font-size:small"></div> </div><span class="gmail-"><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
<br>
Cheers,<br>
Kevin<br>
<br>
[1] <a target="_blank" rel="noreferrer" href="http://en.cppreference.com/w/cpp/compiler_support">http://en.cppreference.com/w/c<wbr>pp/compiler_support</a> for evidence<br>
<div><div><br>
> I am raising this question especially since KTextEditor seems to use<br>
> 'nullptr' in several locations now for several releases - and noone<br>
> complained.<br>
><br>
> Are we supposed to turn nullptr in KTextEditor also into nullptr, or<br>
> can we take the liberty and ditch Q_NULLPTR completely for all<br>
> frameworks?<br>
><br>
> Same also applies to 'override'.<br>
><br>
> Best,<br>
> Dominik<br>
<br>
<br>
</div></div><span><font color="#888888">--<br>
Kevin Funk | <a target="_blank" href="mailto:kfunk@kde.org">kfunk@kde.org</a> | <a target="_blank" rel="noreferrer" href="http://kfunk.org">http://kfunk.org</a></font></span></blockquote></span></div><span class="gmail-HOEnZb"><font color="#888888"><br><br clear="all"><br>-- <br><div>regards, Jaroslaw Staniek<br><br>KDE:<br>: A world-wide network of software engineers, artists, writers, translators<br>: and facilitators committed to Free Software development - <a target="_blank" href="http://kde.org">http://kde.org</a><br>Calligra Suite:<br>: A graphic art and office suite - <a target="_blank" href="http://calligra.org">http://calligra.org</a><br>Kexi:<br>: A visual database apps builder - <a target="_blank" href="http://calligra.org/kexi">http://calligra.org/kexi</a><br>Qt Certified Specialist:<br>: <a target="_blank" href="http://www.linkedin.com/in/jstaniek">http://www.linkedin.com/in/<wbr>jstaniek</a></div>
</font></span></div></div>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature">regards, Jaroslaw Staniek<br><br>KDE:<br>: A world-wide network of software engineers, artists, writers, translators<br>: and facilitators committed to Free Software development - <a target="_blank" href="http://kde.org">http://kde.org</a><br>Calligra Suite:<br>: A graphic art and office suite - <a target="_blank" href="http://calligra.org">http://calligra.org</a><br>Kexi:<br>: A visual database apps builder - <a target="_blank" href="http://calligra.org/kexi">http://calligra.org/kexi</a><br>Qt Certified Specialist:<br>: <a target="_blank" href="http://www.linkedin.com/in/jstaniek">http://www.linkedin.com/in/jstaniek</a></div>
</div></div>