<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128680/">https://git.reviewboard.kde.org/r/128680/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 4th, 2016, 2:34 vorm. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Andreas, any idea which icon the action could use?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would use visibility and hint to show/hide the font's that are not available in the selected font. will the font change to "not selected" grayed out when you show all characters also the ones that aren't available?</p></pre>
<br />
<p>- Andreas</p>
<br />
<p>On September 1st, 2016, 4:45 nachm. UTC, Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, KDE Usability and Andreas Kainz.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated Sept. 1, 2016, 4:45 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=97420">97420</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Adds a toolbutton to the right of the font combobox to control the "font merging" property of QFont. When selected, characters which are not available in the font are disabled.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seeking feedback about:
- placement of the button
- used icon (currently "format-text-strikethrough"; it shows an S character which could stand for "substitution")
- action name and tooltip (see line 477 and 479)
- and code changes ;)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I was unsure if the toolbutton could have a popup menu showing three options:
1) show characters from all fonts
2) disable characters not available in font
3) hide characters not available in font</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">but I did not implement it, because it felt odd not being able to see <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">which</em> characters are not available in the font.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kcharselect.cpp <span style="color: grey">(30ddd34)</span></li>
<li>src/kcharselect_p.h <span style="color: grey">(db0259c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128680/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/7220dddb-ca1b-42a2-966c-791925156baf__snapshot1.png">Character table with font substitution (default)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/67c02866-b12c-4080-b6a4-22e29006448b__snapshot2.png">Character table with dimming substituted characters</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>