<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128843/">https://git.reviewboard.kde.org/r/128843/</a>
</td>
</tr>
</table>
<br />
<p>On září 6th, 2016, 12:17 odp. UTC, <b>Jan Grulich</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Every DeviceType inherits from Device, same as DeviceTypePrivate inherits from DevicePrivate so when DeviceType is connected to PropertiesChanged signal and doesn't implement the slot itself, then it will call the DevicePrivate::dbusPropertiesChanged() slot which is common for all devices. In this slot it calls normal propertiesChanged() slot which calls propertyChanged() implemented by DeviceTypePrivate. This somehow works given inheritance. Even previously the base Device class doesn't connect to PropertiesChanged signal.</p></pre>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Issues discussed personally. And btw. QDBusConnection::connect() doesn't have an option for connection type as QObject::connect() so I cannot use Qt::UniqueConnection.</p></pre>
<br />
<p>- Jan</p>
<br />
<p>On září 6th, 2016, 11:56 dop. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Network Management and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Zář. 6, 2016, 11:56 dop.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
networkmanager-qt
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since NM 1.2.x they switched to using o.f.DBus.Properties for sending PropertiesChanged signal. They still support their previous solution which uses their o.f.NetworkManager.Foo interfaces, but with release of NM 1.4.0 this is a bit broken (altough already fixed in upstream). With the fix for that they marked PropertiesChanged signal for their o.f.NM.Foo interfaces as deprecated and we should be slowly moving towards the standardized o.f.DBus.Properties interface instead.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See https://bugzilla.gnome.org/show_bug.cgi?id=770629</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/accesspoint.cpp <span style="color: grey">(d1abe31)</span></li>
<li>src/accesspoint_p.h <span style="color: grey">(bf111c8)</span></li>
<li>src/activeconnection.cpp <span style="color: grey">(fc8a1ac)</span></li>
<li>src/activeconnection_p.h <span style="color: grey">(d021437)</span></li>
<li>src/adsldevice.cpp <span style="color: grey">(f07b5e6)</span></li>
<li>src/bluetoothdevice.cpp <span style="color: grey">(3ccf276)</span></li>
<li>src/bonddevice.cpp <span style="color: grey">(d9798b0)</span></li>
<li>src/bridgedevice.cpp <span style="color: grey">(f345ad5)</span></li>
<li>src/connection.cpp <span style="color: grey">(5b80a93)</span></li>
<li>src/connection_p.h <span style="color: grey">(5f43d93)</span></li>
<li>src/device.cpp <span style="color: grey">(f7bc7e6)</span></li>
<li>src/device_p.h <span style="color: grey">(da85faf)</span></li>
<li>src/dhcp4config.cpp <span style="color: grey">(efcd98d)</span></li>
<li>src/dhcp4config_p.h <span style="color: grey">(ce5563c)</span></li>
<li>src/dhcp6config.cpp <span style="color: grey">(4f0a3b6)</span></li>
<li>src/dhcp6config_p.h <span style="color: grey">(093f234)</span></li>
<li>src/genericdevice.cpp <span style="color: grey">(a6919d5)</span></li>
<li>src/gredevice.cpp <span style="color: grey">(1f81ea4)</span></li>
<li>src/infinibanddevice.cpp <span style="color: grey">(15b3575)</span></li>
<li>src/macvlandevice.cpp <span style="color: grey">(db2c594)</span></li>
<li>src/manager.cpp <span style="color: grey">(01723d7)</span></li>
<li>src/manager_p.h <span style="color: grey">(d0a9d8c)</span></li>
<li>src/modemdevice.cpp <span style="color: grey">(89394f0)</span></li>
<li>src/olpcmeshdevice.cpp <span style="color: grey">(286a080)</span></li>
<li>src/settings.cpp <span style="color: grey">(f75b86a)</span></li>
<li>src/settings_p.h <span style="color: grey">(466d0a7)</span></li>
<li>src/teamdevice.cpp <span style="color: grey">(543d26d)</span></li>
<li>src/tundevice.cpp <span style="color: grey">(68eb103)</span></li>
<li>src/vethdevice.cpp <span style="color: grey">(bb7c9fd)</span></li>
<li>src/vlandevice.cpp <span style="color: grey">(415dec9)</span></li>
<li>src/vpnconnection.cpp <span style="color: grey">(d2d17e4)</span></li>
<li>src/vpnconnection_p.h <span style="color: grey">(25ba589)</span></li>
<li>src/wimaxdevice.cpp <span style="color: grey">(daec0a6)</span></li>
<li>src/wireddevice.cpp <span style="color: grey">(af147b1)</span></li>
<li>src/wirelessdevice.cpp <span style="color: grey">(dad918d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128843/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>