<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128680/">https://git.reviewboard.kde.org/r/128680/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 25th, 2016, 1:59 a.m. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ping? Can someone please review? It already missed the tr deadline for 5.26, but maybe we can get this into 5.27.</p></pre>
</blockquote>
<p>On August 25th, 2016, 7:41 a.m. UTC, <b>Heiko Tietze</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As far as I understand the change it will show tofu'ed characters in their intended appearance (the example is misleading here) but disable the item so it looks differently and cannot be selected.
* The dialog is quite confusing right now. Since the font name is selected after this pseudo-hierarchical organization, along with the font size that is rather a zoom, I would say adding another button is not diminishing the overall UX. Users will basically search and not browse all the fancy characters. And I agree that a split- or menu button is not needed.
* The icon have to be something else, of course. You may ask Andreas Kainz for that.
* For the text you could say "Highlight applicable characters" and "The currently selected font may not include all unicode characters, which will be dimmed when this option is checked.". But take this as just an idea.
* Btw: What will be the default? Suggest On.
* Code: -
+ What happens when you search for something with having the dim feature enabled? I recommend to also not hide but dim those results.
+ How do you discriminate the non-applicable chars from the non-printable?
o Today I can select the alien chars and add them to the clipboard. Perhaps my target has a different font and for some reason I don't want to change it. This workflow will not be supported anymore when the items are disabled. Very far-fetched workflow, however. Just to mention.</pre>
</blockquote>
<p>On August 25th, 2016, 10:03 a.m. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks, let me clarify: The characters will only be dimmed visually, but they can still be selected. This also applies to search results.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The default is the first screenshot, which is the result of the traditional "font merging" done by Qt, and makes sense if your target document supports all characters regardless of installed fonts.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the example is misleading here</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Could you expand on this?</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The dialog is quite confusing right now</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I am open to ideas for improvements.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How do you discriminate the non-applicable chars from the non-printable?</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Non-printable characters have the disabled background, but no foreground rendering. Characters that are printable, but have no glyph in any installed font are rendered with a replacement rectangle by Qt.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Regarding the suggested tooltip, this will be visible when the user hovers over it, so it should be concise rather than verbose?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Adding Andreas for icon suggestions.</p></pre>
</blockquote>
<p>On August 25th, 2016, 10:22 a.m. UTC, <b>Heiko Tietze</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the example is misleading here
Could you expand on this?</p>
</blockquote>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks like Arial has no diacritical DZ, for instance. Can't be true, or am I wrong?</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The dialog is quite confusing right now
I am open to ideas for improvements.</p>
</blockquote>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry, too much work to dig into. Some time ago I wrote something for LibreOffice that may help http://user-prompt.com/libreoffice-design-session-special-character/</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The characters will only be dimmed visually, but they can still be selected.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It might be strange to have the disabled look but the full functionality. Just check it yourself, and ignore my rant if you think its no problem.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks like Arial has no diacritical DZ</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Indeed my font doesn't have it. The version of Arial that is installed is from the old days, where openSUSE shipped a downloader for Microsoft fonts.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It might be strange to have the disabled look but the full functionality.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I will check if I can fully disable them, and rename the action accordingly.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks for the pointer to the LibreOffice work. Bookmarked/favorite characters will come with https://git.reviewboard.kde.org/r/128522/ but that's only for the KCharSelect application, not the widget.</p></pre>
<br />
<p>- Christoph</p>
<br />
<p>On August 25th, 2016, 10:03 a.m. UTC, Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, KDE Usability and Andreas Kainz.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated Aug. 25, 2016, 10:03 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=97420">97420</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Adds a toolbutton to the right of the font combobox to control the "font merging" property of QFont. When selected, characters which are not available in the font are dimmed (i.e. look disabled).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seeking feedback about:
- placement of the button
- used icon (currently "format-text-strikethrough"; it shows an S character which could stand for "substitution")
- action name and tooltip (see line 477 and 479)
- and code changes ;)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I was unsure if the toolbutton could have a popup menu showing three options:
1) show characters from all fonts
2) dim characters not available in font
3) hide characters not available in font</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">but I did not implement it, because it felt odd not being able to see <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">which</em> characters are not available in the font.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kcharselect.cpp <span style="color: grey">(45c1e99)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128680/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/7220dddb-ca1b-42a2-966c-791925156baf__snapshot1.png">Character table with font substitution (default)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/67c02866-b12c-4080-b6a4-22e29006448b__snapshot2.png">Character table with dimming substituted characters</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>