<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128739/">https://git.reviewboard.kde.org/r/128739/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 23rd, 2016, 1:27 nachm. CEST, <b>Heiko Becker</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">?[12:11] ?<?sandsmark?>? commit it if someone can test with the appropriate Qt versions
...
?[12:13] ?<?veqz?>? hmm, I have the right Qt versions. I can download the pat-
...
?[12:31] ?<?veqz?>? heirecka: I ended up applying to patch manually..., and it compiles fine now :)</pre>
</blockquote>
<p>On August 23rd, 2016, 1:48 nachm. CEST, <b>Burkhard Lück</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Your patch breaks build with Qt 5.6.1 for me</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I need this patch on to of yours to get it build:
index 4607966..abc50af 100644
--- a/src/core/guesslanguage.cpp
+++ b/src/core/guesslanguage.cpp
@@ -489,7 +489,7 @@ GuessLanguagePrivate::GuessLanguagePrivate()
case QChar::Script_WarangCiti:
names = getNames(QLocale::VarangKshitiScript);
break;
-#if QT_VERSION >= QT_VERSION_CHECK(5, 6, 0)
+#if QT_VERSION > QT_VERSION_CHECK(5, 6, 1)
case QChar::Script_Ahom:
names = getNames(QLocale::AhomScript);
break;</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, sorry about that. I misread git's output, when determining in which qt version it had landed. Fixed with: https://quickgit.kde.org/?p=sonnet.git&a=commit&h=3d7d09fb7bae81ab5d277c1862b85955df96f1f5</pre>
<br />
<p>- Heiko</p>
<br />
<p>On August 23rd, 2016, 1:28 nachm. CEST, Heiko Becker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.</div>
<div>By Heiko Becker.</div>
<p style="color: grey;"><i>Updated Aug. 23, 2016, 1:28 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
sonnet
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Also correct the other #ifdef because like QChar::Script_SignWriting
0e1f3aab11a4310595d8651c02ce5f9d60c93252 in qtbase.git introduced the
other enums as well. That commit was first released with Qt 5.6
BUG: 366789
CCMAIL: martin.sandsmark@kde.org</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Haven't an old Qt around, tested building with 5.7. though.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/guesslanguage.cpp <span style="color: grey">(5c5239fbe99c9a3ea95bd07dc4d0ec6582897379)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128739/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>