<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128627/">https://git.reviewboard.kde.org/r/128627/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 8th, 2016, 2:53 p.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128627/diff/1/?file=473742#file473742line307" style="color: black; font-weight: bold; text-decoration: underline;">src/widgets/kurlrequester.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">306</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">edit</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KLineEdit</span><span class="p">(</span><span class="n">m_parent</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">307</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">edit</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KLineEdit</span><span class="p">(</span><span class="n">m_parent</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here is setted sender, it cannot be nullptr.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This code isn't called when combo is non-null (as set on line 274), so the lineedit can indeed be null.</p></pre>
<br />
<p>- David</p>
<br />
<p>On August 8th, 2016, 7:38 a.m. UTC, Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2016, 7:38 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">avoid connecting KUrl from null</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">before the patch, there was 4 connect(null, .....), that crashed within:
#0 0x00007ffff441f975 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1 0x00007ffff4420d8a in __GI_abort () at abort.c:78
#2 0x00007ffff50ca6e5 in QMessageLogger::warning(char const*, ...) const (context=..., message=...)
at global/qlogging.cpp:1648
#3 0x00007ffff50ca6e5 in QMessageLogger::warning(char const*, ...) const (this=this@entry=0x7fffffffc270, msg=msg@entry=0x7ffff5412a58 "QObject::connect: invalid null parameter") at global/qlogging.cpp:557
#4 0x00007ffff52ec011 in QObjectPrivate::connectImpl(QObject const*, int, QObject const*, void**, QtPrivate::QSlotObjectBase*, Qt::ConnectionType, int const*, QMetaObject const*) (sender=sender@entry=0x0, signal_index=<optimized out>, receiver=receiver@entry=0xb7c970, slot=slot@entry=0x7fffffffc420, slotObj=slotObj@entry=0xb58500, type=Qt::AutoConnection, types=0x0, senderMetaObject=0x7ffff6a81900 <QLineEdit::staticMetaObject>) at kernel/qobject.cpp:4674
#5 0x00007ffff52ec2d2 in QObject::connectImpl(QObject const*, void**, QObject const*, void**, QtPrivate::QSlotObjectBase*, Qt::ConnectionType, int const*, QMetaObject const*) (sender=sender@entry=0x0, signal=signal@entry=0x7fffffffc410, receiver=receiver@entry=0xb7c970, slot=slot@entry=0x7fffffffc420, slotObj=0xb58500, type=Qt::AutoConnection, types=0x0, senderMetaObject=0x7ffff6a81900 <QLineEdit::staticMetaObject>)
at kernel/qobject.cpp:4658
#6 0x00007ffff7ef2465 in KUrlRequester::KUrlRequesterPrivate::init() (type=Qt::AutoConnection, slot=
(void (KUrlRequester::*)(KUrlRequester * const, const QString &)) 0x7ffff7eee1c0 <KUrlRequester::textChanged(QString const&)>, receiver=0xb7c970, signal=
(void (QLineEdit::*)(QLineEdit * const, const QString &)) 0x7ffff64d34b0 <QLineEdit::textChanged(QString const&)>, sender=0x0) at /usr/include/qt5/QtCore/qobject.h:239
applying the patch, kate starts (there is no connect from null)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/widgets/kurlrequester.cpp <span style="color: grey">(77e7c1d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128627/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>