<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128590/">https://git.reviewboard.kde.org/r/128590/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Plasma, Matthias Klumpp, and Harald Sitter.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Aug. 4, 2016, 2:38 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 469f5a0a0bf7c9e99a8447af2bfa8789dbef145c by Aleix Pol to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kpackage
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We want our components to be exposed on software using Appstream (such as Discover, but not exclusively). Some of the most hidden components we have nowadays are Plasma addons, since they're not documented there. This attempts to fix this by reusing the metadata we already have and turning it into files that appstream can consume, without having to write yet another time the plugin metadata.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is done in 2 steps:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Introduces <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">kpackagetool5 --appstream-metainfo</code> argument</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The cmake macro will automatically grab the file and process it. See: https://git.reviewboard.kde.org/r/128579/</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tests pass, everything else still compiles (including r128579), we get quite some metadata.
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">appstreamcli validate</code> doesn't choke on output files.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KF5PackageMacros.cmake <span style="color: grey">(9163de9)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(c84379d)</span></li>
<li>autotests/data/testfallbackpackage/testfallbackpackage.appdata.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/testjsonmetadatapackage/testjsonmetadatapackage.appdata.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/testpackage/testpackage.appdata.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kpackagetoolappstreamtest.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kpackagetool/kpackagetool.h <span style="color: grey">(dc056c6)</span></li>
<li>src/kpackagetool/kpackagetool.cpp <span style="color: grey">(2758f70)</span></li>
<li>src/kpackagetool/main.cpp <span style="color: grey">(a8eb5ab)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128590/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>