<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120000/">https://git.reviewboard.kde.org/r/120000/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120000/diff/4/?file=472682#file472682line53" style="color: black; font-weight: bold; text-decoration: underline;">src/unit.h</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">53</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ThermalConductivityCategory</span><span class="p">,</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You should add @since KF 5.26 markers to all the new enums in this file.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Explanation: If noone disagrees with this before, i'll commit it for KF 5.26 just after KF 5.25 is released (since it has lots of new strings to give time to translators).</p></pre>
</div>
</div>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On August 1st, 2016, 4:01 a.m. UTC, Garret Wassermann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Garret Wassermann, John Layt, and Petri Damstén.</div>
<div>By Garret Wassermann.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2016, 4:01 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kunitconversion
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">New Thermal and Electrical Units and Convienience Function for KUnitConversion</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I added some fundamental (base SI) units as well as some common derived units in SI and English/Imperial system, mostly for electrical or thermal units. I also added a simple member function to the Value class, symbolAsString(), to immediately receive the current unit assigned to the Value object as a QString. I was running into issues with my code where doing v.unit()->symbol() wasn't working because I was getting KSharedPointers instead of the object, and the program would just crash. I just wanted the string! So I made a function, which helped with testing of the units.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The new categories work fine under my test program. I was able to convert thermal units back and forth in my test program, so seems ok. The values also appear correct from my tests (as long as I didn't mess anything up by hand!).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">First time submitting review, so please let me know if there is something else I should do better next time, thank you.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>README.md <span style="color: grey">(fe8cbe8)</span></li>
<li>src/converter.cpp <span style="color: grey">(0a7f862)</span></li>
<li>src/electrical_current.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/electrical_current_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/electrical_resistance.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/electrical_resistance_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/energy.cpp <span style="color: grey">(f525031)</span></li>
<li>src/thermal_conductivity.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/thermal_conductivity_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/thermal_flux.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/thermal_flux_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/thermal_generation.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/thermal_generation_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/unit.h <span style="color: grey">(e440346)</span></li>
<li>src/voltage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/voltage_p.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120000/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>