<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128515/">https://git.reviewboard.kde.org/r/128515/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">He, this is the very same patch that I found in the fork/copy of KDescendantsProxyModel in the sources of Marble when I updated it to latest KF5 version. Actually that patch there was done in 2012 but seems it never got upstreamed, can someone please fix the (L)GPL to require patches to be at least reported to upstream!1! Meh.
I cannot remember what bugged me about this very code when I tried to reason why it fixes things that I went instead for the version in https://git.reviewboard.kde.org/r/128398/ But as said in the comment there, I have not had grasped the complete logic and hoped for guidance by Stephen :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So given this patch here completes the autotests, also matches that previous patch found in Marble and still works fine in Marble, it has my "Ship it" :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks for picking this up and getting to a proper test and seemingly better fix, Sune & David.</p></pre>
<br />
<p>- Friedrich W. H. Kossebau</p>
<br />
<p>On July 24th, 2016, 9:14 p.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Friedrich W. H. Kossebau, Stephen Kelly, and Sune Vuorela.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated July 24, 2016, 9:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kitemmodels
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes Sune's unittest.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just the unittest.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kdescendantsproxymodeltest.cpp <span style="color: grey">(67c0fba5bdcf700659889731f80043911af211fb)</span></li>
<li>src/kdescendantsproxymodel.cpp <span style="color: grey">(477cd961e57bd8d8863f543aac1c7ac806bff24c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128515/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>