<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128566/">https://git.reviewboard.kde.org/r/128566/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 1st, 2016, 3:42 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For testing against a stable version, please also include the following two commits:
7b24b834384a1524d8c2126416916a62048107cc
e5b2a8b2506adbfa2a659afd5d8cb9aa28db22dd</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">patch with those commits included: https://paste.kde.org/piaxvjxj3</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On August 1st, 2016, 3:33 p.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2016, 3:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So far KWindowSystem had a custom implementation to monitor the
compositing selection using XFixes and an own event filter. This
change simplifies it by porting to KSelectionWatcher to share more
code. While the XFixes approach is actually better it's also fighting
with Qt which might result in events getting lost. At least we have
reports about the code being racy at startup.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kwindoweffectstest.cpp <span style="color: grey">(921bdb60d2ff0bd33f6dede9b4ca999740eb1eeb)</span></li>
<li>src/platforms/xcb/kwindowsystem.cpp <span style="color: grey">(fbff381b61116c6eef47d5c7fa1fc5730857328c)</span></li>
<li>src/platforms/xcb/kwindowsystem_p_x11.h <span style="color: grey">(72df642bef4b3562dd44882a94661476a9772c2b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128566/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>