<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128465/">https://git.reviewboard.kde.org/r/128465/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I like the idea, and the code changes LGTM. But I think the autotest can be improved by ensuring that the short-term caching of the 'unknown' status of a non-existent icon works, instead of just ensuring that the cache is ignored once enough time has elapsed.
i.e. something like
// find non-existent icon
// verify its null
// install test icon (don't reset time-to-elapse yet)
// find previously-non-existent icon
// verify it's reported as null (this means we're caching its status)
// reset time-to-elapse to zero
// find previously-non-existent icon again
// verify it's valid and exists
I suppose this would make it more of a case of how it's implemented than what it's meant to do, but since caching the unknown-edness of a non-existent icon is what actually gives us the speedup we want, I think it makes sense to make sure we don't accidentally break that later.</pre>
<br />
<p>- Michael Pyne</p>
<br />
<p>On July 16th, 2016, 9:52 a.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Christoph Feck, David Rosca, Michael Pyne, and Olivier Goffart.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated July 16, 2016, 9:52 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kiconthemes
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Summary:
The code said "unknown icons should be searched for anew each time
[so that installing new icons works]". However this leads to massive
performance issues when opening the file dialog in a dir with many
files for which there is no mimetype icon.
In my case, 293 callgrind.out.* files in one dir (it's ironic that
they would create a huge performance issue...).
To make both sides happy (installing new icons should still work, but
still unknown icons shouldn't lead to a full disk search every time
icon.isNull() or icon.pixmap() is called), let's re-resolve unknown
icons again only after 5 seconds.
Benchmark results for loading an unavailable icon :
before: 43 msecs per iteration (1897 disk locations checked)
after: 0.013 msecs per iteration (pixmap found in the on-disk cache)
And the file dialog no longer crawls to a halt in the dir with 293 callgrind files.
Test Plan:
Reviewers:
Subscribers:</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(described in commit log)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kiconengine_unittest.cpp <span style="color: grey">(105e86c1e7bc6170c626aa80d34cdb6422acca9c)</span></li>
<li>src/kiconloader.cpp <span style="color: grey">(d885318c166f2a996b038218366317615886a14e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128465/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>