<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128456/">https://git.reviewboard.kde.org/r/128456/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Shane Synan.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">NotifyByLogfile</code> back to <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">CMakeLists.txt</code> and <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">knotificationmanager.cpp</code> now that it's been ported to KF5/Qt5. This fixes <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Log to file</code> failing to function as expected, e.g. when configured by <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KNotifyConfig</code>.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See commit <a href="https://quickgit.kde.org/?p=knotifications.git&a=commit&h=a8d13825ec4e7fe00dc8eae4aec7042ceb6ce4ee" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">a8d13825ec4e7fe00dc8eae4aec7042ceb6ce4ee</a></p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Environment used:
- Ubuntu 16.04 x86_64
- Quassel client and/or monolithic 0.12.2
- Ubuntu repos: <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">quassel-client</code> or <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">quassel</code>
- Any application that generates notifications with KNotifications and allows configuring the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Log to file</code> option should work
- KNotifications from master branch
- For Ubuntu 16.04, CMake configuration needs tweaked to compile alongside other KDE 5.18.0 components</p>
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Set up the program to generate a notification
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">For Quassel monolithic, go through setup, connect to Freenode as some nick</em></li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Configure notifications to use the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Log to file</code> option
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">For Quassel, <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Settings ? Configure Notifications…</code>, and enable <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Log to file</code> for all options, including the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">… when focused</code> variants</em>
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Note: due to an unrelated dependency issue where <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">libkf5notifications5</code> does not pull in <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">phonon4qt5</code>, you <strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">also</strong> need to either install <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">phonon4qt5</code> or uncheck <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Play a sound</code> for all options</em></li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Generate a notification
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">For Quassel, open Freenode web-chat, send your Quassel nickname a message</em></li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Observe that the log file is <strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">not</strong> updated</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Apply this patch, replacing the system installed copy of libKF5Notifications.so
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">For Ubuntu 16.04 with modified <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">CMakeLists.txt</code>, <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">sudo cp ~/path/to/knotifications-build/src/libKF5Notifications.so.5.18.0 /usr/lib/x86_64-linux-gnu/libKF5Notifications.so.5.18.0</code></em></li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Restart the notification program, generate a notification again</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Observe that the log file is updated</li>
</ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(7eb3125)</span></li>
<li>src/knotificationmanager.cpp <span style="color: grey">(c315db9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128456/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>