<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128289/">https://git.reviewboard.kde.org/r/128289/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 LGTM</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On June 26th, 2016, 12:17 p.m. CEST, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated June 26, 2016, 12:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Instead of bool return value, V2 provides an int (job error) return value.
This allows to differenciate between "user canceled" and "error communicating
with kpasswdserver". This is important because upon "user canceled" the job
just finishes silently, so the user thinks the operation succeeded when in fact
it got silently canceled, very dangerous.
The actual communication error dated from when kpasswdserver was in kded
rather than kiod (and on a computer with kded5 not installed), but still,
let's make this robust to avoid a possible data loss situation.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">dolphin ftp://foo@davidfaure.fr/</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">when cancelling, no error</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">when uninstalling kiod5 and killing it, "Communication with local password server failed" error appears</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/global.h <span style="color: grey">(aa8082a3d02df5f808e2667cbb6ceaa4131f86ce)</span></li>
<li>src/core/job_error.cpp <span style="color: grey">(e1feeb5c5803f5302cd853075a66b45742df577b)</span></li>
<li>src/core/slavebase.h <span style="color: grey">(77e991e16a256c2ac687760895e4c609e45bf6de)</span></li>
<li>src/core/slavebase.cpp <span style="color: grey">(d8082bc514eab859a9a6308dae716a23a2b4a895)</span></li>
<li>src/ioslaves/ftp/ftp.cpp <span style="color: grey">(335422d6f9a4d60558591b4d4c7835fb55028e57)</span></li>
<li>src/ioslaves/http/http.cpp <span style="color: grey">(50f062dc3cb8654da18ebb56d5b92b5330595784)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128289/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>