<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127926/">https://git.reviewboard.kde.org/r/127926/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 18th, 2016, 2:16 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A better approach I think would be to have a simple checkbox, store
that in a config and then have KNotification/NotifyByAudio simply
do nothing if that config/value is present.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Or even have KNotificationManager::notify(..) skip audio action.</p></pre>
</blockquote>
<p>On May 18th, 2016, 4:48 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sounds complementary to this approach, actually.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The approach in this patch works better IMHO for disabling all sounds for -one- event source.
A checkbox wouldn't make sense for that purpose (contradictory with the info in the listview), but a global checkbox "disable all sound notifications" would make sense indeed, for those who prefer that.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The people in the bug report had both use cases.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ping?</p></pre>
<br />
<p>- David</p>
<br />
<p>On May 15th, 2016, 10:53 a.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Edmundson and Olivier Goffart.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated May 15, 2016, 10:53 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=157272">157272</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifyconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This saves a lot of clicking compared to selecting each event
in the list and unchecking the "Play sound" checkbox, something
I have to do any time I set up a new computer (for me or around the office).
CCBUG: 157272</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm calling this method from a button in the KCM: http://www.davidfaure.fr/2016/kcmnotify.diff</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My initial idea was a "disable all sounds for all event sources" button, but the underlying classes don't make this easy to support (I'd have to literally set every item as current in the combo, leading to a strange user-visible automation happening). Disabling all sounds for the current event source (app) is already quite a time saver.
Plus this way the change isn't saved yet, it can still be cancelled by pressing Cancel, like any other change -except- selecting another app.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/knotifyconfigwidget.h <span style="color: grey">(bf122bd9e30982f0fa0d022d04aeadee4fb181dc)</span></li>
<li>src/knotifyconfigwidget.cpp <span style="color: grey">(06125ea9da565cbc14c8afa1155c723605b42da6)</span></li>
<li>src/knotifyeventlist.h <span style="color: grey">(b6bd43ed40f9b2a18d41300760a6c01dca52907d)</span></li>
<li>src/knotifyeventlist.cpp <span style="color: grey">(6913148869a7be6b267668e44888f1a432b2396b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127926/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>