<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128103/">https://git.reviewboard.kde.org/r/128103/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 19th, 2016, 10:37 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See https://git.reviewboard.kde.org/r/114979/</p></pre>
</blockquote>
<p>On June 19th, 2016, 10:38 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">At least i agree with the "not eating such a common install path".</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe we need to either convice distros to put something there or use a more kf-centric install path?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It might just be easier to make the license text a hyperlink to the official license text and skip the install altogether. Alternately I'm fine with a KF5-specific path, that part's easy. The issue is that when we removed the license install we left out the part where we deprecated things like <a href="https://api.kde.org/frameworks/kcoreaddons/html/classKAboutLicense.html#a6f78a3c04d397f613581dfee85d98a87" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">KAboutLicense::text()</a> that our Frameworks are documented as providing. Of course providing only a hyperlink is also an API change but it would be SC/BC and we can at least self-document the change.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Either way I don't think it's a good idea to try convincing distros to install licenses just to make our own code work properly. Each distro already has their own ways of advertising the licenses their packages are distributed under so I don't think they'd see a need to do additional work here.</p></pre>
<br />
<p>- Michael</p>
<br />
<p>On June 4th, 2016, 10:19 p.m. UTC, Michael Pyne wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Michael Pyne.</div>
<p style="color: grey;"><i>Updated June 4, 2016, 10:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=353939">353939</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change fixes a regression from KDE 4 by importing the license texts from KDE4's kdelibs for the non-GPL licenses and for FSF's *GPL licenses downloading the plain text directly from the source. I don't see the licenses in any other KF5 module, and KCoreAddons is what hosts KAboutLicense/KAboutData so it makes sense to land here.
This permits the "License: $foo" hyperlink in the KAboutDialog to work properly as well (previously there'd be a blank spot where the license would be, now it shows up".
Since I was working here I added LGPL v2.1 as a separate license, since it has slightly different requirements to the old LGPL v2.0 (and obviously, to LGPL v3). I can make that part a separate RR (or just leave it out, I don't know of any apps using LGPL v2.1 off hand).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, and installs. Once installed, apps have their licenses show up when those licenses are in the set of well-known licenses we provide.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/CMakeLists.txt <span style="color: grey">(466d714)</span></li>
<li>src/lib/kaboutdata.h <span style="color: grey">(9fe4ade)</span></li>
<li>src/lib/kaboutdata.cpp <span style="color: grey">(2be3b62)</span></li>
<li>src/lib/licenses/ARTISTIC <span style="color: grey">(e69de29)</span></li>
<li>src/lib/licenses/BSD <span style="color: grey">(e69de29)</span></li>
<li>src/lib/licenses/CMakeLists.txt <span style="color: grey">(e69de29)</span></li>
<li>src/lib/licenses/GPL_V2 <span style="color: grey">(e69de29)</span></li>
<li>src/lib/licenses/GPL_V3 <span style="color: grey">(e69de29)</span></li>
<li>src/lib/licenses/LGPL_V2 <span style="color: grey">(e69de29)</span></li>
<li>src/lib/licenses/LGPL_V21 <span style="color: grey">(e69de29)</span></li>
<li>src/lib/licenses/LGPL_V3 <span style="color: grey">(e69de29)</span></li>
<li>src/lib/licenses/QPL_V1.0 <span style="color: grey">(e69de29)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128103/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>