<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128190/">https://git.reviewboard.kde.org/r/128190/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 15th, 2016, 7:14 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Does it make that the (in)famouse Qt patch for paths is not required anymore?</p></pre>
</blockquote>
<p>On June 15th, 2016, 7:18 p.m. UTC, <b>Christoph Cullmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">At least for me, I can now compile e.g. kconfigwidgets that uses meinproc3 for generating docs just fine with stock Qt (5.7.0, from last rc installer)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I get just:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[9/67] Generating preparetips5.1
Warn: AUTHOR sect.: no personblurb|contrib for Matthias Kiefer <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
preparetips5
Note: AUTHOR sect.: see see http://docbook.sf.net/el/contrib <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
preparetips5
Note: AUTHOR sect.: see see http://docbook.sf.net/el/personblurb <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
preparetips5
Note: Writing preparetips5.1</p></pre>
</blockquote>
<p>On June 15th, 2016, 7:21 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks; the warning is fine, just few tags missing but the page is generated. I guess you meant meinproc5, unless we are back to 2004 :)</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">:=) yeah, meinproc5 :P
I still need to see how complex docs build, but at least "can I find my own assets" seems to work now nicely.</p></pre>
<br />
<p>- Christoph</p>
<br />
<p>On June 15th, 2016, 7:18 p.m. UTC, Christoph Cullmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure, Kevin Funk, Luigi Toscano, and Hannah von Reth.</div>
<div>By Christoph Cullmann.</div>
<p style="color: grey;"><i>Updated June 15, 2016, 7:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not rely on standardpaths to detect stuff installed by KDocTools on its own (like the customizations).
This allows to compile documentation on Mac without patches (and I guess same goes for Windows).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">make && make install kdoctools</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">e.g. make in kio now builds documentation without errors about not found stuff on mac.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>config-kdoctools.h.cmake <span style="color: grey">(280adbc)</span></li>
<li>src/xslt.cpp <span style="color: grey">(59b0538)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128190/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>