<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127928/">https://git.reviewboard.kde.org/r/127928/</a>
     </td>
    </tr>
   </table>
   <br />



<p>

Ship it!

</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As for the other similar revisions, this is a no-brainer (again after 5.23).</p></pre>
 <br />









<p>- Luigi Toscano</p>


<br />
<p>On maggio 15th, 2016, 3:31 p.m. CEST, Burkhard Lück wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for KDE Frameworks, Localization and Translation (l10n) and David Faure.</div>
<div>By Burkhard Lück.</div>


<p style="color: grey;"><i>Updated Mag. 15, 2016, 3:31 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">rename directory + adapt CMakeLists.txt file</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this change is necessary to fetch translated kioslave docs 
without hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Together with commiting this change I'll adapt Scripty.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">builds and installs the kcm docs to the same installdir as before</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>docs/CMakeLists.txt <span style="color: grey">(7d23a35)</span></li>

 <li>docs/kioslave/CMakeLists.txt <span style="color: grey">(127af91)</span></li>

 <li>docs/kioslave/data/CMakeLists.txt <span style="color: grey">(3c5edda)</span></li>

 <li>docs/kioslave/data/index.docbook <span style="color: grey">(2cb24b4)</span></li>

 <li>docs/kioslave/file/CMakeLists.txt <span style="color: grey">(bdcc8dd)</span></li>

 <li>docs/kioslave/file/index.docbook <span style="color: grey">(38e9d05)</span></li>

 <li>docs/kioslave/ftp/CMakeLists.txt <span style="color: grey">(2a6b6dd)</span></li>

 <li>docs/kioslave/ftp/index.docbook <span style="color: grey">(6e7e475)</span></li>

 <li>docs/kioslave/help/CMakeLists.txt <span style="color: grey">(98cb154)</span></li>

 <li>docs/kioslave/help/documentationnotfound/CMakeLists.txt <span style="color: grey">(22394d6)</span></li>

 <li>docs/kioslave/help/documentationnotfound/index.docbook <span style="color: grey">(c7d6822)</span></li>

 <li>docs/kioslave/help/index.docbook <span style="color: grey">(3c5d822)</span></li>

 <li>docs/kioslave/http/CMakeLists.txt <span style="color: grey">(efeaa02)</span></li>

 <li>docs/kioslave/http/index.docbook <span style="color: grey">(c3fbef8)</span></li>

 <li>docs/kioslave/mailto/CMakeLists.txt <span style="color: grey">(96185b8)</span></li>

 <li>docs/kioslave/mailto/index.docbook <span style="color: grey">(2878ece)</span></li>

 <li>docs/kioslave/telnet/CMakeLists.txt <span style="color: grey">(067fd33)</span></li>

 <li>docs/kioslave/telnet/index.docbook <span style="color: grey">(d1bda3d)</span></li>

 <li>docs/kioslave/webdav/CMakeLists.txt <span style="color: grey">(a767168)</span></li>

 <li>docs/kioslave/webdav/index.docbook <span style="color: grey">(35f1b99)</span></li>

 <li>docs/kioslave5/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>docs/kioslave5/data/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>docs/kioslave5/data/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>docs/kioslave5/file/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>docs/kioslave5/file/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>docs/kioslave5/ftp/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>docs/kioslave5/ftp/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>docs/kioslave5/help/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>docs/kioslave5/help/documentationnotfound/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>docs/kioslave5/help/documentationnotfound/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>docs/kioslave5/help/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>docs/kioslave5/http/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>docs/kioslave5/http/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>docs/kioslave5/mailto/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>docs/kioslave5/mailto/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>docs/kioslave5/telnet/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>docs/kioslave5/telnet/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>docs/kioslave5/webdav/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>docs/kioslave5/webdav/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127928/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>