<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126017/">https://git.reviewboard.kde.org/r/126017/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Jeremy Whiting.</div>
<div>By Andreas Cord-Landwehr.</div>
<p style="color: grey;"><i>Updated June 6, 2016, 7:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit c15b1404887020da65b4ba478bface6f827d58e1 by Andreas Cord-Landwehr to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knewstuff
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The debug output is provided as categorized debug output and can be
enabled/disabled simply by users using the QT_LOGGING_RULES environment
variable. Hence, provide output by default and let the user optionally
activate it.
Also use a more descriptive name for the debug category by using the
common reverse domain notation "org.kde.knewstuff".</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/attica/atticaprovider.cpp <span style="color: grey">(07508b05f324f25481bf05c5717c0ca60dce70d1)</span></li>
<li>src/entry.cpp <span style="color: grey">(09f954267a5b71e2340f4e6ce9f6d311845aace5)</span></li>
<li>src/ui/itemsgridviewdelegate.cpp <span style="color: grey">(9636ccf150f5db81863b7d16bf166b6623c77ff5)</span></li>
<li>src/ui/itemsviewbasedelegate.cpp <span style="color: grey">(e89068939c3c41ce281dbd4b628a218b022a3afb)</span></li>
<li>tests/khotnewstuff.cpp <span style="color: grey">(2bfff35b136faf22bb41c92136f5bed96c1c9efe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126017/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>