<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128019/">https://git.reviewboard.kde.org/r/128019/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">While I appreciate the source of this change (I've almost never hit F1 intending to open the doucmentation myself), I don't think a RR is the right place to discuss changes to our default shortcuts. This takes a small survey of a small section of our community. I think the VDG would probably be the best place to have a discussion about what help, if any, is triggered and on what shortcut (though if there is a better source I'm happy to take their input instead). Once there is a consensus, then I'm happy to have those changes implemented.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since there is a global way to disable F1 for people who find this annoying now, this is a -2 from me. People annoyed at F1 can fix their issue now without code changes while we figure out the best plan forward.</p></pre>
<br />
<p>- Matthew Dawson</p>
<br />
<p>On May 25th, 2016, 7:01 p.m. EDT, Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and KDE Usability.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated May 25, 2016, 7:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">F1 is too important and too easy to trigger for something like Help, that be honest you don't need a shortcut for (since you don't invoke Help that often).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/gui/kstandardshortcut.cpp <span style="color: grey">(6be6309)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128019/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>