<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127887/">https://git.reviewboard.kde.org/r/127887/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127887/diff/2/?file=464635#file464635line383" style="color: black; font-weight: bold; text-decoration: underline;">src/core/installation.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">383</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">installdir</span> <span class="o">=</span> <span class="n">QStandardPaths</span><span class="o">::</span><span class="n"><span class="hl">standardL</span>ocat<span class="hl">ions</span></span><span class="p">(</span><span class="n">QStandardPaths</span><span class="o">::</span><span class="n">GenericDataLocation</span><span class="p"><span class="hl">).</span></span><span class="n"><span class="hl">last</span></span><span class="p"><span class="hl">()</span></span><span class="hl"> </span><span class="o"><span class="hl">+</span></span><span class="hl"> </span><span class="sc"><span class="hl">'/'</span></span><span class="hl"> </span><span class="o"><span class="hl">+</span></span> <span class="n">targetDirectory</span> <span class="o">+</span> <span class="sc">'/'</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">382</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">installdir</span> <span class="o">=</span> <span class="n">QStandardPaths</span><span class="o">::</span><span class="n"><span class="hl">l</span>ocat<span class="hl">e</span></span><span class="p">(</span><span class="n">QStandardPaths</span><span class="o">::</span><span class="n">GenericDataLocation</span><span class="p"><span class="hl">,</span></span> <span class="n">targetDirectory</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">QStandardPaths</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">LocateDirectory</span></span><span class="p"><span class="hl">)</span></span> <span class="o">+</span> <span class="n"><span class="hl">QLatin1Char</span></span><span class="p"><span class="hl">(</span></span><span class="sc">'/'</span><span class="p"><span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't know if this does the same but also didn't test.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127887/diff/2/?file=464638#file464638line201" style="color: black; font-weight: bold; text-decoration: underline;">src/kmoretools/kmoretoolsconfigdialog_p.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">201</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">Q_FOREACH</span></span> <span class="p">(</span><span class="k">const</span> <span class="n">KmtMenuItemDto</span><span class="o">&</span> <span class="n">registeredService</span><span class="p"><span class="hl">,</span></span> <span class="n">notInstalledServices</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">201</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k"><span class="hl">for</span></span> <span class="p">(</span><span class="k">const</span> <span class="n">KmtMenuItemDto</span><span class="o">&</span> <span class="nl">registeredService</span><span class="hl"> </span><span class="p"><span class="hl">:</span></span> <span class="n">notInstalledServices</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I wonder why here "for" is better than Q_FOREACH.</p></pre>
</div>
</div>
<br />
<p>- Gregor Mi</p>
<br />
<p>On May 11th, 2016, 11:01 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Jeremy Whiting.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated May 11, 2016, 11:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knewstuff
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Mostly clazy fixes, few cleanups</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds, tests pass.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/installation.cpp <span style="color: grey">(1887d0f)</span></li>
<li>src/kmoretools/kmoretools.h <span style="color: grey">(32da22c)</span></li>
<li>src/kmoretools/kmoretools.cpp <span style="color: grey">(8bd6751)</span></li>
<li>src/kmoretools/kmoretoolsconfigdialog_p.cpp <span style="color: grey">(466b887)</span></li>
<li>src/kmoretools/kmoretoolsmenufactory.cpp <span style="color: grey">(aad3f00)</span></li>
<li>src/kmoretools/kmoretoolspresets.cpp <span style="color: grey">(679e849)</span></li>
<li>src/staticxml/staticxmlprovider.cpp <span style="color: grey">(541bf57)</span></li>
<li>src/ui/itemsviewdelegate.cpp <span style="color: grey">(7001be2)</span></li>
<li>tests/kmoretools/kmoretoolstest_interactive.cpp <span style="color: grey">(b1cbdea)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127887/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>