<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127905/">https://git.reviewboard.kde.org/r/127905/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Christoph Feck and Marco Martin.</div>
<div>By Harald Sitter.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kiconthemes
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is to prevent incorrect default themes when a themeplugin is
available
current icon theme is now decided as follows
- application config contains Icons/Theme config
- QIcon has a theme set
- kdelogbals config contains Icons/Theme config
- hard coded default
for all these steps hicolor is excluded as valid option as it is not a
complete icon theme on its own, so we'd rather have the hardcoded default
intead of plain hicolor (since we inherit hicolor anyway)
This improves icon theming in the following ways
a) without kdeglobals we don't always end up using the default (oxygen)
b) with a theme plugin any environment can force a theme different from
what is set in kdeglobals. this in particular would for example allow
xfce/gnome/unity to have a platform plugin and use the correct icons
even when the application uses kiconthemes.
a) in particular was causing the entire workspace on first login to use
oxygen if startup was too fast so that kde4breeze would not have written
a kdeglobals file with Theme=breeze by the time plasma started.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">test all scenarios.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">unfortunately I couln't figure out a way to take the theme plugin out of the equation to unit test this consistently even when a theme plugin is available</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kicontheme.cpp <span style="color: grey">(23bbb4e8010691fcfb1d3af386c0eab10dc91385)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127905/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>