<html><head></head><body><div style="color:#000; background-color:#fff; font-family:HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:16px"><div id="yui_3_16_0_ym19_1_1461569007967_3244"><span>I object.</span></div><div id="yui_3_16_0_ym19_1_1461569007967_3277"><br><span></span></div><div dir="ltr" id="yui_3_16_0_ym19_1_1461569007967_3283"><span id="yui_3_16_0_ym19_1_1461569007967_3348">a) I already told you, don't use something nobody else uses, use the separate repos</span></div><div id="yui_3_16_0_ym19_1_1461569007967_3342" dir="ltr"><span id="yui_3_16_0_ym19_1_1461569007967_3351">b) Not going to happen, but why would it matter at all?<br></span></div><div id="yui_3_16_0_ym19_1_1461569007967_3352" dir="ltr"><br><span id="yui_3_16_0_ym19_1_1461569007967_3351"></span></div><div id="yui_3_16_0_ym19_1_1461569007967_3461" dir="ltr"><span id="yui_3_16_0_ym19_1_1461569007967_3351">More reasons for it:</span></div><div id="yui_3_16_0_ym19_1_1461569007967_3462" dir="ltr"><span id="yui_3_16_0_ym19_1_1461569007967_3351"> c) ASAN does not check for things in the library being broken or not since it only works on code compiled with ASAN, so the crashes are not in the library, they are in your code (if they are because of the library being broken or not that's not important, *your* code is the one that is going to crash)<br></span></div><div id="yui_3_16_0_ym19_1_1461569007967_3463" dir="ltr"><span id="yui_3_16_0_ym19_1_1461569007967_3351"> d) Hiding your head in the sand and saying "this is not my fault it's Qt's fault" is not going to fix the fact that your code is crashing<br></span></div><div id="yui_3_16_0_ym19_1_1461569007967_3521" dir="ltr"><span id="yui_3_16_0_ym19_1_1461569007967_3351"> e) We've uncovered bugs that otherwise would have bitten us and nobody would have bothered fixing because they would be hardly reproducible, both in our code and in Qt's code, that is a *good* thing, not a bad thing.</span></div><div id="yui_3_16_0_ym19_1_1461569007967_3648" dir="ltr"><br><span id="yui_3_16_0_ym19_1_1461569007967_3351"></span></div><div dir="ltr"><br><span id="yui_3_16_0_ym19_1_1461569007967_3351"></span></div><div id="yui_3_16_0_ym19_1_1461569007967_3522" dir="ltr"><span id="yui_3_16_0_ym19_1_1461569007967_3351">Let's not move backwards.</span><br></div><div id="yui_3_16_0_ym19_1_1461569007967_3243" class="qtdSeparateBR"><div><br></div><div>Cheers,</div><div> Albert<br></div><div><br></div></div><div style="display: block;" id="yui_3_16_0_ym19_1_1461569007967_3240" class="yahoo_quoted"> <div id="yui_3_16_0_ym19_1_1461569007967_3239" style="font-family: HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 16px;"> <div id="yui_3_16_0_ym19_1_1461569007967_3238" style="font-family: HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 16px;"> <div id="yui_3_16_0_ym19_1_1461569007967_3241" dir="ltr"> <font id="yui_3_16_0_ym19_1_1461569007967_3242" face="Arial" size="2"> <hr size="1"> <b><span style="font-weight:bold;">De:</span></b> Ben Cooksley <bcooksley@kde.org><br> <b><span style="font-weight: bold;">Para:</span></b> Martin Graesslin <mgraesslin@kde.org> <br><b><span style="font-weight: bold;">CC:</span></b> Scarlett Clark <sgclark@kde.org>; "kde-frameworks-devel@kde.org" <kde-frameworks-devel@kde.org><br> <b><span style="font-weight: bold;">Enviado:</span></b> Lunes 25 de abril de 2016 9:14<br> <b><span style="font-weight: bold;">Asunto:</span></b> Re: Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux, gcc - Build # 11 - Still Unstable!<br> </font> </div> <div id="yui_3_16_0_ym19_1_1461569007967_3237" class="y_msg_container"><br>On Mon, Apr 25, 2016 at 5:59 PM, Martin Graesslin <<a shape="rect" ymailto="mailto:mgraesslin@kde.org" href="mailto:mgraesslin@kde.org">mgraesslin@kde.org</a>> wrote:<br clear="none">> On Saturday, April 23, 2016 8:48:17 PM CEST Ben Cooksley wrote:<br clear="none">>> On Sat, Apr 23, 2016 at 8:35 PM, Martin Graesslin <<a shape="rect" ymailto="mailto:mgraesslin@kde.org" href="mailto:mgraesslin@kde.org">mgraesslin@kde.org</a>><br clear="none">> wrote:<br clear="none">>> > On Saturday, April 23, 2016 1:09:00 PM CEST Ben Cooksley wrote:<br clear="none">>> >> On Sat, Apr 23, 2016 at 1:04 PM, Daniel Vrátil <<a shape="rect" ymailto="mailto:dvratil@kde.org" href="mailto:dvratil@kde.org">dvratil@kde.org</a>> wrote:<br clear="none">>> >> > On Saturday, April 23, 2016 1:44:16 AM CEST Ben Cooksley wrote:<br clear="none">>> >> >> On Fri, Apr 22, 2016 at 11:11 PM, David Faure <<a shape="rect" ymailto="mailto:faure@kde.org" href="mailto:faure@kde.org">faure@kde.org</a>> wrote:<br clear="none">>> >> >> > On Thursday 21 April 2016 14:57:52 <a shape="rect" ymailto="mailto:no-reply@kde.org" href="mailto:no-reply@kde.org">no-reply@kde.org</a> wrote:<br clear="none">>> >> >> >> GENERAL INFO<br clear="none">>> >> >> >><br clear="none">>> >> >> >> BUILD UNSTABLE<br clear="none">>> >> >> >> Build URL:<br clear="none">>> >> >> >> <a shape="rect" href="https://build.kde.org/job/kdbusaddons%20master%20kf5-qt5/PLATFORM=L" target="_blank">https://build.kde.org/job/kdbusaddons%20master%20kf5-qt5/PLATFORM=L</a><br clear="none">>> >> >> >> inu<br clear="none">>> >> >> >> x,<br clear="none">>> >> >> >> compiler=gcc/11/><br clear="none">>> >> >> ><br clear="none">>> >> >> > Wow, ASAN detected a real bug in Qt here.<br clear="none">>> >> >> ><br clear="none">>> >> >> > Fixed in <a shape="rect" href="https://codereview.qt-project.org/156728" target="_blank">https://codereview.qt-project.org/156728</a><br clear="none">>> >> >><br clear="none">>> >> >> As this issue essentially breaks any test on the CI system that<br clear="none">>> >> >> depends on Qt I suggest all developers affected by this indicate this<br clear="none">>> >> >> on the relevant reviews.<br clear="none">>> >> ><br clear="none">>> >> > Hey guys,<br clear="none">>> >><br clear="none">>> >> Hi David,<br clear="none">>> >><br clear="none">>> >> > any chance to get this patch into our Qt build on the CI since it has<br clear="none">>> >> > been<br clear="none">>> >> > integrated upstream now? As it affects all tests that interact with<br clear="none">>> >> > DBus<br clear="none">>> >> > it<br clear="none">>> >> > would be nice to resolve this on the CI.<br clear="none">>> >><br clear="none">>> >> We'll need upstream to update qt5.git (I think that's still required<br clear="none">>> >> for changes to fully flow through) I think.<br clear="none">>> >> We could try to hack the patch in, but then we'll end up having to<br clear="none">>> >> undo that in a few weeks time.<br clear="none">>> ><br clear="none">>> > Could we disable that ASAN check please[1]? I have two of my projects<br clear="none">>> > failing due to the DBus problem and one further failing due to a similar<br clear="none">>> > problem in QQuickStyleItem [2]. It's nice that we find errors, but I<br clear="none">>> > rather not have my tests fail due to errors in Qt.<br clear="none">>><br clear="none">>> That would just cover up the issue.<br clear="none">><br clear="none">> Yes it would and that's exactly what I want.<br clear="none">><br clear="none">> To me the CI is currently producing false positives. It started to break from<br clear="none">> one moment to the other. It costs time to look into why it started to fail. It<br clear="none">> means that till that problem is fixed in Qt I cannot trust the CI system. It<br clear="none">> results in nobody noticing real breakage, because the build is broken anyway.<br clear="none">><br clear="none">> Then there is the problem of responsibility: I look at the output, I have no<br clear="none">> idea why that thing is broken, I have no idea how to build a minimal example<br clear="none">> which would reproduce it, even less on how to fix it. That's just a really bad<br clear="none">> situation to have a CI which can be trusted.<br clear="none">><br clear="none">> In summary: I don't want spend time to investigate false positives. If an<br clear="none">> option results in false positives, I think that we should disable it.<br clear="none"><br clear="none">Understandable.<br clear="none"><br clear="none">><br clear="none">> Of course Qt should get those bugs fixed, but for that Qt should enable ASAN on<br clear="none">> their CI system. If we get libraries which are free of ASAN problems, then we<br clear="none">> can enable it on our side. But false positives are just bad.<br clear="none"><br clear="none">Based on this i'm going to assume Qt is not ASAN compliant, and will<br clear="none">therefore be disabling ASAN for all KDE projects across the entire KDE<br clear="none">CI system in 24 hours unless nobody objects.<br clear="none"><br clear="none">Objectors can be expected to place pressure on the appropriate<br clear="none">processes within the Qt Project to:<br clear="none">a) Get the necessary changes flowed through into qt5.git so we can<br clear="none">pick them up (the existing process is painfully slow)<br clear="none">b) Get their CI system to check for ASAN issues.<br clear="none"><br clear="none">><br clear="none">> Cheers<br clear="none">> Martin<br clear="none"><br clear="none">Regards,<div class="yqt2330491190" id="yqtfd01644"><br clear="none">Ben<br clear="none">_______________________________________________<br clear="none">Kde-frameworks-devel mailing list<br clear="none"><a shape="rect" ymailto="mailto:Kde-frameworks-devel@kde.org" href="mailto:Kde-frameworks-devel@kde.org">Kde-frameworks-devel@kde.org</a><br clear="none"><a shape="rect" href="https://mail.kde.org/mailman/listinfo/kde-frameworks-devel" target="_blank">https://mail.kde.org/mailman/listinfo/kde-frameworks-devel</a><br clear="none"></div><br><br></div> </div> </div> </div></div></body></html>