<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127122/">https://git.reviewboard.kde.org/r/127122/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Март 28th, 2016, 11:22 след обяд EEST, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hmm. Do we really need code for that? Can't you simply assign those buttons to the forward / backward actions as shortcuts? Try setting them as alternate shortcuts by default.</p></pre>
</blockquote>
<p>On Март 28th, 2016, 11:24 след обяд EEST, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This code is needed. QKeySequence is about <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">only</em> for keyboard keys. Mouse buttons <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">must</em> me handled by event, as far i know.</p></pre>
</blockquote>
<p>On Март 28th, 2016, 11:29 след обяд EEST, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Did you actually try that in the shortcut dialog? Please do. I don't have a mouse with extra keys here right now ...</p></pre>
</blockquote>
<p>On Март 28th, 2016, 11:36 след обяд EEST, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just tried, I cannot assign any mouse buttons to shortcuts, including back/forward.</p></pre>
</blockquote>
<p>On Март 28th, 2016, 11:36 след обяд EEST, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not only try, i saw the code in kxmlgui who set this shortcuts. It's used QKeySequence who is keyboard specific. You can see the same code as this patch in Dolphin for for/backward.</p></pre>
</blockquote>
<p>On Март 28th, 2016, 11:42 след обяд EEST, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hmm, ok then. I'm undecided, let's wait for a few other opinions. On the one hand, it sounds sensible, on the other hand I don't like hardcoded shortcuts and the use case to switch documents with mouse is ... not a huge one imo. Code looks ok.</p></pre>
</blockquote>
<p>On Март 29th, 2016, 2:11 преди обяд EEST, <b>Nicolás Alvarez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My mouse has back/forward buttons (by tilting the scroll wheel sideways) and I find it super useful in a web browser. But if the buttons were supported in Kate, it's more likely I'd want to configure it for undo/redo rather than document switching.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I was thinking to make a module for kxmlgui, to install event listener for all kxmlgui client and providing configurable mouse + keyboard shortcuts. But i'dont know Martin G or someone else not works on that in KWin ?!
I prefer document switch because ctrl+z fits left hand action + mouse ese, alt+left not.</p></pre>
<br />
<p>- Anthony</p>
<br />
<p>On Март 28th, 2016, 11:20 след обяд EEST, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Kate, KDE Frameworks, Christoph Cullmann, Dominik Haumann, and Kåre Särs.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Март 28, 2016, 11:20 след обяд</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Show prev/next tab on mouse back/forward buttons</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/katemainwindow.h <span style="color: grey">(ece0db8)</span></li>
<li>kate/katemainwindow.cpp <span style="color: grey">(f630e28)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127122/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>