<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127398/">https://git.reviewboard.kde.org/r/127398/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 18th, 2016, 5:20 a.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127398/diff/1/?file=453383#file453383line63" style="color: black; font-weight: bold; text-decoration: underline;">src/knotification.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Private</span><span class="p">()</span> <span class="o">:</span> <span class="n">id</span><span class="p">(</span><span class="mi"><span class="hl">0</span></span><span class="p">),</span> <span class="n">ref</span><span class="p">(</span><span class="mi">0</span><span class="p">),</span> <span class="n">widget</span><span class="p">(</span><span class="mi">0l</span><span class="p">),</span> <span class="n">needUpdate</span><span class="p">(</span><span class="nb">false</span><span class="p">)</span> <span class="p">{}</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Private</span><span class="p">()</span> <span class="o">:</span> <span class="n">id</span><span class="p">(</span><span class="o"><span class="hl">-</span></span><span class="mi"><span class="hl">1</span></span><span class="p">),</span> <span class="n">ref</span><span class="p">(</span><span class="mi">0</span><span class="p">),</span> <span class="n">widget</span><span class="p">(</span><span class="mi">0l</span><span class="p">),</span> <span class="n">needUpdate</span><span class="p">(</span><span class="nb">false</span><span class="p">)</span> <span class="p">{}</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ref can't be UINT_MAX, but id can, no? Negative rage will brake all, it's this possible, maybe not. Counters it's not good idea to be signed.</p></pre>
</blockquote>
<p>On March 21st, 2016, 5:04 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes...if your application will emit more than 32767 notifications in its lifetime. At which point the application is probalby broken.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is it? I don't use KTP, but assuming KTP sends Knotifications and assuming you get like 1 chat notification per minute (not crazy imho) get say around 500 notifications per day, so in 66 days you'd go over the limit. Sure it's corner-case-y but i would not call it impossible nor the app being broken</p></pre>
<br />
<p>- Albert</p>
<br />
<p>On March 16th, 2016, 8:23 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated March 16, 2016, 8:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds basic set of unit tests including fake notifications server.
This helped uncover and fix these issues:
* Calling close() on KNotification that was not "sent" would not emit closed() and would not delete it
* Closing a notification can delete the KNotification object prematurely
* Invoking an action leads to unnecessary dbus roundtrip
* Invoking an action would fail to properly close and delete the KNotification object</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Unit tests all pass.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(6d09051)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/fake_notifications_server.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/fake_notifications_server.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/knotification_test.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/knotifications5/qttest.notifyrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/qtest_dbus.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/knotification.cpp <span style="color: grey">(17b0be2)</span></li>
<li>src/knotificationmanager.cpp <span style="color: grey">(e80d48c)</span></li>
<li>src/knotificationplugin.cpp <span style="color: grey">(acf964c)</span></li>
<li>src/notifybypopup.cpp <span style="color: grey">(b9489c1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127398/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>