<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127415/">https://git.reviewboard.kde.org/r/127415/</a>
</td>
</tr>
</table>
<br />
<p>
Fix it, then Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested with glibc, didn't lead to multiple definitions warning -> looks good to me.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127415/diff/1/?file=453557#file453557line83" style="color: black; font-weight: bold; text-decoration: underline;">src/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">83</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">set_source_files_properties(kdesu_stub.c PROPERTIES<span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">trailing whitespace</p></pre>
</div>
</div>
<br />
<p>- David Faure</p>
<br />
<p>On March 18th, 2016, 12:41 a.m. UTC, Wiktor W Brodlo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Wiktor W Brodlo.</div>
<p style="color: grey;"><i>Updated March 18, 2016, 12:41 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdesu
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The file kdesu_stub.c calls the following functions: putenv, unsetenv, initgroups, mkstemp, popen, pclose. Looking at the man pages, this set requires the _XOPEN_SOURCE and _BSD_SOURCE feature test macros to be defined. This patch passes these definitions to the compiler. This enables kdesu to be built against the musl libc, which is very strict about these things.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Without the patch, the build fails as follows:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">src<span style="color: #666666">/</span>kdesu_stub.c<span style="color: #666666">:</span> In <span style="color: #008000; font-weight: bold">function</span> <span style="border: 1px solid #FF0000">‘</span>xsetenv<span style="border: 1px solid #FF0000">’</span><span style="color: #666666">:</span>
src<span style="color: #666666">/</span>kdesu_stub.c<span style="color: #666666">:136:5:</span> error<span style="color: #666666">:</span> implicit declaration of <span style="color: #008000; font-weight: bold">function</span> <span style="border: 1px solid #FF0000">‘</span>putenv<span style="border: 1px solid #FF0000">’</span> <span style="color: #BC7A00">[</span><span style="color: #7D9029">-Werror</span><span style="color: #666666">=</span>implicit<span style="color: #7D9029">-function-declaration</span><span style="color: #BC7A00">]</span>
<span style="color: #008000; font-weight: bold">return</span> putenv(s); <span style="color: #408080; font-style: italic">/* yes: no free()! */</span>
<span style="color: #666666">^</span>
src<span style="color: #666666">/</span>kdesu_stub.c<span style="color: #666666">:</span> In <span style="color: #008000; font-weight: bold">function</span> <span style="border: 1px solid #FF0000">‘</span>main<span style="border: 1px solid #FF0000">’</span><span style="color: #666666">:</span>
src<span style="color: #666666">/</span>kdesu_stub.c<span style="color: #666666">:258:9:</span> error<span style="color: #666666">:</span> implicit declaration of <span style="color: #008000; font-weight: bold">function</span> <span style="border: 1px solid #FF0000">‘</span>unsetenv<span style="border: 1px solid #FF0000">’</span> <span style="color: #BC7A00">[</span><span style="color: #7D9029">-Werror</span><span style="color: #666666">=</span>implicit<span style="color: #7D9029">-function-declaration</span><span style="color: #BC7A00">]</span>
unsetenv(<span style="color: #BA2121">"LC_ALL"</span>);
<span style="color: #666666">^</span>
src<span style="color: #666666">/</span>kdesu_stub.c<span style="color: #666666">:301:9:</span> error<span style="color: #666666">:</span> implicit declaration of <span style="color: #008000; font-weight: bold">function</span> <span style="border: 1px solid #FF0000">‘</span>initgroups<span style="border: 1px solid #FF0000">’</span> <span style="color: #BC7A00">[</span><span style="color: #7D9029">-Werror</span><span style="color: #666666">=</span>implicit<span style="color: #7D9029">-function-declaration</span><span style="color: #BC7A00">]</span>
<span style="color: #008000; font-weight: bold">if</span> (initgroups(pw<span style="color: #666666">-></span>pw_name, pw<span style="color: #666666">-></span>pw_gid) <span style="color: #666666">==</span> <span style="color: #666666">-1</span>) {
<span style="color: #666666">^</span>
src<span style="color: #666666">/</span>kdesu_stub.c<span style="color: #666666">:331:13:</span> error<span style="color: #666666">:</span> implicit declaration of <span style="color: #008000; font-weight: bold">function</span> <span style="border: 1px solid #FF0000">‘</span>mkstemp<span style="border: 1px solid #FF0000">’</span> <span style="color: #BC7A00">[</span><span style="color: #7D9029">-Werror</span><span style="color: #666666">=</span>implicit<span style="color: #7D9029">-function-declaration</span><span style="color: #BC7A00">]</span>
fd2 <span style="color: #666666">=</span> mkstemp(xauthority);
<span style="color: #666666">^</span>
src<span style="color: #666666">/</span>kdesu_stub.c<span style="color: #666666">:342:13:</span> error<span style="color: #666666">:</span> implicit declaration of <span style="color: #008000; font-weight: bold">function</span> <span style="border: 1px solid #FF0000">‘</span>popen<span style="border: 1px solid #FF0000">’</span> <span style="color: #BC7A00">[</span><span style="color: #7D9029">-Werror</span><span style="color: #666666">=</span>implicit<span style="color: #7D9029">-function-declaration</span><span style="color: #BC7A00">]</span>
fout <span style="color: #666666">=</span> popen(<span style="color: #BA2121">"xauth >/dev/null 2>&1"</span>, <span style="color: #BA2121">"w"</span>);
<span style="color: #666666">^</span>
src<span style="color: #666666">/</span>kdesu_stub.c<span style="color: #666666">:342:18:</span> warning<span style="color: #666666">:</span> assignment makes pointer from integer without a cast
fout <span style="color: #666666">=</span> popen(<span style="color: #BA2121">"xauth >/dev/null 2>&1"</span>, <span style="color: #BA2121">"w"</span>);
<span style="color: #666666">^</span>
src<span style="color: #666666">/</span>kdesu_stub.c<span style="color: #666666">:348:13:</span> error<span style="color: #666666">:</span> implicit declaration of <span style="color: #008000; font-weight: bold">function</span> <span style="border: 1px solid #FF0000">‘</span>pclose<span style="border: 1px solid #FF0000">’</span> <span style="color: #BC7A00">[</span><span style="color: #7D9029">-Werror</span><span style="color: #666666">=</span>implicit<span style="color: #7D9029">-function-declaration</span><span style="color: #BC7A00">]</span>
pclose(fout);
<span style="color: #666666">^</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With the patch, the build passes and kdesu works.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(73ff883)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127415/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>