<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125965/">https://git.reviewboard.kde.org/r/125965/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok so I shipped this because I realized KHolidays is still part
of KDE Applications and not Frameworks and KDE apps have dependency
freeze tonight, so I'm pushing this now in order to have the events
done in Plasma 5.7.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The QByteArrayLiterals can still be fixed once I get the answer
to the issue.</p></pre>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On March 16th, 2016, 10:24 p.m. CET, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and John Layt.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated March 16, 2016, 10:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kholidays
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For now it contains just the model of holiday regions
which will be used in the Plasma calendar events
configuration.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Applet configuration contains proper list of available
holiday regions.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e8b7970)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(c067b6c)</span></li>
<li>src/declarative/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarative/holidayregionsmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarative/holidayregionsmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarative/kholidaysdeclarativeplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarative/kholidaysdeclarativeplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarative/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125965/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>