<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On 7 March 2016 at 10:46, Jaroslaw Staniek <span dir="ltr"><<a href="mailto:staniek@kde.org" target="_blank">staniek@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On 18 February 2016 at 18:25, Kåre Särs <span dir="ltr"><<a href="mailto:kare.sars@iki.fi" target="_blank">kare.sars@iki.fi</a>></span> wrote:<br></span><div><div class="h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div>On Thursday, February 18, 2016 02:51:58 PM René J.V. Bertin wrote:<br>
> On Thursday February 18 2016 13:55:18 Jaroslaw Staniek wrote:<br>
> >>> > since QIcon::fromTheme() apaprently isn't able to find app icons.<br>
><br>
> Care to explain? QIcon::fromTheme() doesn't find anything "out of the box"<br>
> on OS X (and I presume on MS Windows), but that is only because no theme<br>
> search path is set on those platforms. When you add the standard XDG icon<br>
> repository to the icon search path on OS X, even "pure" Qt5 application<br>
> will start showing icons all over if you have an icon theme installed --<br>
> including in widgets that should not have icons according to the HIG. Also<br>
> on OS X, fromTheme() will only return the application icon (as in the icon<br>
> shown in the Finder) if the current theme defines that same icon for the<br>
> calling application, and the theme search path is set of course. In all<br>
> other cases it will not, because the application icon is not defined<br>
> through a theme on OS X (nor is it on MS Windows, I presume).<br>
> >> I think the solution with a packaged breeze icons resource working<br>
> >> out-of-the box could be a good (lightweight) addition for non-Plasma<br>
> >> (non-Linux?) users of KF5, to popularize KF5. They grab the icons package<br>
><br>
> Popularise, with Breeze "art"work? O:-)<br>
> Anyway, I don't think "grabbing an icon package" will work on OS X, not if<br>
> you want to create standalone app bundles which by definition contain<br>
> everything they need.<br>
> >> and icons just work without thousands of files, caching, etc. 'One in a<br>
> >> million' would of these users would be interested in theming.<br>
><br>
> I'd up that estimate if we're still talking about Breeze icons here O:-)<br>
><br>
> >> PS2: I have been beaten by situations such as KToolBar setting 0-size<br>
> >> icons by default.<br>
><br>
> Partly this is because almost no KF5 code uses the fallback argument of<br>
> QIcon::fromTheme() explicitly, which means that the function returns an<br>
> empty icon if the search fails. In particular, statements like<br>
><br>
> app->setWindowIcon(QIcon::fromTheme(programName))<br>
><br>
> should read<br>
><br>
> app->setWindowIcon(QIcon::fromTheme(programName, app->windowIcon()))<br>
><br>
> >> This is in a Windows env where no themes are (properly) installed. If the<br>
> >> rcc-based solution is in use I would imagine that ideally all the KF5<br>
> >> code<br>
> >> detects this somehow and would not look for xdg standard themes through<br>
> >> the<br>
> >> classic KIconLoader but silently adapt so the rcc resource works great.<br>
> >> Just a dream.<br>
><br>
> If your rcc resource corresponds to the resource mentioned in the<br>
> QIcon::fromTheme() documentation (I think that talks about "qrc") and if I<br>
> interpret that documentation correctly then yes, code using that function<br>
> will find icons from the rcc/qrc "builtin" resource over those in xdg<br>
> themes (if the XDG icon repository is even in the icon theme search path).<br>
> >>> What I don't know however is whether artists consider that these icons<br>
> >>> should be themeable...<br>
><br>
> I think icon artists will consider that you should touch their icons (for<br>
> theming or anything else). They will probably also consider that their<br>
> icons are the "best" but they really should also consider it a right for<br>
> anyone to use other icons ;)<br>
><br>
<br>
</div></div>The breeze.rcc file way is actually how Christoph solved it in Kate for<br>
Windows and OSX. We create an .rcc file from the breeze icons and at start-up<br>
we search for the file in QStandardPaths::DataLocation and if the file is<br>
found we load it with registerResource() and add ":/icons" to the<br>
themeSearchPaths. (kate.git/icons.h)<br>
<br>
Christoph also added ":/icons" to the search path in kicontheme so that xmlgui<br>
toolbars and friends also get the icons from the .rcc file.<br>
<br>
We get all the same icons as on Linux neatly in one file :)<br></blockquote></div></div><div><br><div style="font-family:monospace,monospace;font-size:small">Thanks, it works on Windows (no platform theme).<br>How to make it work on Linux too (KF5 <span>5.19</span>.0, Qt 5.5.1), i.e. I'd like to have only used icons from the .rcc regardless of availability of FrameworkIntegrationPlugin.so KDEPlatformTheme.so?<br><br></div><div style="font-family:monospace,monospace;font-size:small">We're talking about this code:</div><br><div style="font-family:monospace,monospace;font-size:small"><a href="https://quickgit.kde.org/?p=kate.git&a=blob&f=icons.h" target="_blank">https://quickgit.kde.org/?p=kate.git&a=blob&f=icons.h</a></div><br>As soon as QResource::registerResource("breeze.rcc") is called, ":/icons" is <div style="font-family:monospace,monospace;font-size:small;display:inline">appended to the theme search path (checked using QIcon::themeSearchPaths()).<br><br>There's a line QIcon::setThemeSearchPaths(QStringList() << QStringLiteral(":/icons")).<br><br>- When I have this line enabled and I have no FrameworkIntegrationPlugin.so & KDEPlatformTheme.so installed, no icons are available at all<br><br>- When I have this line disabled, breeze XDG theme is used but kexi icons (from the .rcc file are missing), regardless of availability of FrameworkIntegrationPlugin.so & KDEPlatformTheme.so.<br><br></div><br><div style="font-family:monospace,monospace;font-size:small">For the record, Qt 5.5's code is:</div><br><div style="font-family:monospace,monospace;font-size:small">QIcon QIcon::fromTheme(const QString &name, const QIcon &fallback)<br>{<br> QIcon icon;<br><br> if (qtIconCache()->contains(name)) {<br> icon = *qtIconCache()->object(name);<br> } else {<br> QPlatformTheme * const platformTheme = QGuiApplicationPrivate::platformTheme();<br> bool hasUserTheme = QIconLoader::instance()->hasUserTheme();<br> QIconEngine * const engine = (platformTheme && !hasUserTheme) ? platformTheme->createIconEngine(name)<br> : new QIconLoaderEngine(name);<br> QIcon *cachedIcon = new QIcon(engine);<br> icon = *cachedIcon;<br> qtIconCache()->insert(name, cachedIcon);<br> }<br><br> // Note the qapp check is to allow lazy loading of static icons<br> // Supporting fallbacks will not work for this case.<br> if (qApp && icon.availableSizes().isEmpty())<br> return fallback;<br><br> return icon;<br>}<br></div></div></div></div></div></blockquote><div><br><div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline">BTW: The only difference between Kexi and Kate here is that Kate has no "own" icons at all that are installed by themes.<br>Commit 0a31a2d7630ccfed5cf19 by Christoph in kate.git makes changes such as:<br><br> if (pk.contains(fieldName))<br>- item->setIcon(0, QIcon::fromTheme(QLatin1String("sql-field-pk")));<br>+ item->setIcon(0, QIcon(QLatin1String(":/katesql/pics/16-actions-sql-field-pk.png")));<br> else<br><br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline">- it works because it omits the themes API while I am trying to use app-defined icons through QIcon::fromTheme() in Kexi. Without that I'd have to duplicate logic of icon themes just to make QIcon::fromTheme() work cross-platform.<br></div></div></div><br><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">Any ideas what is missing?<br></div><br clear="all"><br>-- <br><div class="gmail_signature">regards, Jaroslaw Staniek<br><br>KDE:<br>: A world-wide network of software engineers, artists, writers, translators<br>: and facilitators committed to Free Software development - <a href="http://kde.org" target="_blank">http://kde.org</a><br>Calligra Suite:<br>: A graphic art and office suite - <a href="http://calligra.org" target="_blank">http://calligra.org</a><br>Kexi:<br>: A visual database apps builder - <a href="http://calligra.org/kexi" target="_blank">http://calligra.org/kexi</a><br>Qt Certified Specialist:<br>: <a href="http://www.linkedin.com/in/jstaniek" target="_blank">http://www.linkedin.com/in/jstaniek</a></div>
</div></div>