<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126940/">https://git.reviewboard.kde.org/r/126940/</a>
     </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for KDE Frameworks, Alex Richardson and David Faure.</div>
<div>By Christoph Cullmann.</div>


<p style="color: grey;"><i>Updated March 6, 2016, 2:58 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit a3fee508c6c42b1b86155719e38a84b1128360eb by Christoph Cullmann to branch master.</pre>
  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Move .protocol files of all io slaves bundled in kio to JSON meta data.
Second try, this time with i18n aware protocoltojson used.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compile and tests seem to work, this time the i18n strings look better in trash.json, compared to my first try in https://git.reviewboard.kde.org/r/125869/</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/kprotocolinfotest.cpp <span style="color: grey">(812f7f7)</span></li>

 <li>src/ioslaves/file/CMakeLists.txt <span style="color: grey">(cb85cfb)</span></li>

 <li>src/ioslaves/file/file.cpp <span style="color: grey">(381e488)</span></li>

 <li>src/ioslaves/file/file.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ioslaves/file/file.protocol <span style="color: grey">(523c0f5)</span></li>

 <li>src/ioslaves/ftp/CMakeLists.txt <span style="color: grey">(04f5600)</span></li>

 <li>src/ioslaves/ftp/ftp.cpp <span style="color: grey">(7477a6a)</span></li>

 <li>src/ioslaves/ftp/ftp.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ioslaves/ftp/ftp.protocol <span style="color: grey">(4c5f80c)</span></li>

 <li>src/ioslaves/help/CMakeLists.txt <span style="color: grey">(867b59d)</span></li>

 <li>src/ioslaves/help/ghelp.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ioslaves/help/ghelp.protocol <span style="color: grey">(d2a642a)</span></li>

 <li>src/ioslaves/help/help.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ioslaves/help/help.protocol <span style="color: grey">(1deefe5)</span></li>

 <li>src/ioslaves/help/main.cpp <span style="color: grey">(9939196)</span></li>

 <li>src/ioslaves/help/main_ghelp.cpp <span style="color: grey">(59c8558)</span></li>

 <li>src/ioslaves/http/CMakeLists.txt <span style="color: grey">(da5601e)</span></li>

 <li>src/ioslaves/http/http.cpp <span style="color: grey">(a84129f)</span></li>

 <li>src/ioslaves/http/http.protocol <span style="color: grey">(49e5dc5)</span></li>

 <li>src/ioslaves/http/https.protocol <span style="color: grey">(c15d06f)</span></li>

 <li>src/ioslaves/http/webdav.protocol <span style="color: grey">(05c977a)</span></li>

 <li>src/ioslaves/http/webdavs.protocol <span style="color: grey">(d5e4b2f)</span></li>

 <li>src/ioslaves/trash/CMakeLists.txt <span style="color: grey">(05161cd)</span></li>

 <li>src/ioslaves/trash/kio_trash.cpp <span style="color: grey">(81cc036)</span></li>

 <li>src/ioslaves/trash/trash.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ioslaves/trash/trash.protocol <span style="color: grey">(7430575)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126940/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>