<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127266/">https://git.reviewboard.kde.org/r/127266/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and kdewin.</div>
<div>By Thomas Friedrichsmeier.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
khtml
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix building with MinGW on Windows, by removing conflicting FOCUS_EVENT (also "OPTIONAL" and "CreateEvent") defines. Note that there already is a similar #undef in dom2_eventsimpl.h, but this is ineffective, if the Windows defines are added after dom2_eventsimpl.h was (first) included.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">First, I tried solving this by shuffling around includes, but gave up on this path after quite some trial and error. (Main route of inclusion for windows.h seems to be khtml_part.h -> parts/browserextension.h -> Platform includes.)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now builds with MinGW.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ecma/kjs_dom.cpp <span style="color: grey">(e3fedad)</span></li>
<li>src/ecma/kjs_html.cpp <span style="color: grey">(cc3c08a)</span></li>
<li>src/html/html_baseimpl.cpp <span style="color: grey">(539681c)</span></li>
<li>src/html/html_elementimpl.cpp <span style="color: grey">(7569192)</span></li>
<li>src/html/htmlparser.cpp <span style="color: grey">(064b99b)</span></li>
<li>src/xml/dom_docimpl.cpp <span style="color: grey">(4f0be5c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127266/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>