<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127215/">https://git.reviewboard.kde.org/r/127215/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 29th, 2016, 8:14 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127215/diff/1/?file=445933#file445933line65" style="color: black; font-weight: bold; text-decoration: underline;">src/sycoca/kbuildmimetypefactory.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">65</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n"><span class="hl">dirName</span></span><span class="hl"> </span><span class="o"><span class="hl">==</span></span><span class="hl"> </span><span class="s">"packages"</span><span class="p">)</span> <span class="p">{</span> <span class="c1">// special subdir</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">59</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n"><span class="hl">QLatin1String</span></span><span class="p"><span class="hl">(</span></span><span class="s">"packages"</span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="o"><span class="hl">==</span></span><span class="hl"> </span><span class="n"><span class="hl">dirName</span></span><span class="p">)</span> <span class="p">{</span> <span class="c1">// special subdir</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can you keep the order of the operands? I find
if (var == constant)
more readable than the other way around.
("is this car green?", not "is green the color of this car?"). In any case that's how it is everywhere in KF5 AFAIK.</p></pre>
</blockquote>
<p>On February 29th, 2016, 12:28 p.m. UTC, <b>Nick Shaforostoff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i have changed to a natural order. but the problem is that i couldn't find an appropriate operator== overload taking (qstringref, qlatin1string), there is only a (qlatin1string, qstringref) one. is that a qt bug that should be fixed?</p></pre>
</blockquote>
<p>On March 1st, 2016, 11:03 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sounds like it.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i have reported the bug, but it was closed as invalid: turns out there is such overload, but it is not reflected in the reference</p></pre>
<br />
<p>- Nick</p>
<br />
<p>On February 29th, 2016, 12:27 p.m. UTC, Nick Shaforostoff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Nick Shaforostoff.</div>
<p style="color: grey;"><i>Updated Feb. 29, 2016, 12:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changes are mostly related to containers/iterators, but there are also few QString related optimizations
note that i have made a switch from QLinkedList to just QList because it performs better for T=<void*>
also i have changed QStringList to QSet<QString> in one place to make the code run faster</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">all tests pass, except kmimeassociationstest (fakeApplicationService is NULL), but it fails also without my changes</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/services/kservice.cpp <span style="color: grey">(c75bce2)</span></li>
<li>src/services/kservicetype.cpp <span style="color: grey">(2a73ccd)</span></li>
<li>src/sycoca/kbuildmimetypefactory.cpp <span style="color: grey">(340f76a)</span></li>
<li>src/sycoca/kbuildservicefactory.cpp <span style="color: grey">(a74f2e8)</span></li>
<li>src/sycoca/kbuildsycoca.cpp <span style="color: grey">(e99e906)</span></li>
<li>src/sycoca/kmimeassociations.cpp <span style="color: grey">(9423b27)</span></li>
<li>src/sycoca/ksycocadict.cpp <span style="color: grey">(f33d01a)</span></li>
<li>src/sycoca/ksycocafactory.cpp <span style="color: grey">(e410581)</span></li>
<li>src/sycoca/ksycocautils_p.h <span style="color: grey">(8db26b0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127215/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>