<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126523/">https://git.reviewboard.kde.org/r/126523/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 29th, 2016, 10:23 p.m. UTC, <b>Andreas Kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">hi, heiko fill a bug report cause you cant see the x icon https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that knewpassworddialog use an icon cause there is no x icon. is this icon used from KNewPasswordDialog? can it be colored in white #f2f2f2. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">thanks for the feedback. maybe you can answer on the bug report.</p></pre>
</blockquote>
<p>On February 29th, 2016, 10:40 p.m. UTC, <b>Elvis Angelaccio</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi. The problem is the X icon/button in this screenshot: https://git.reviewboard.kde.org/r/126523/file/2643/</p></pre>
</blockquote>
<p>On February 29th, 2016, 10:41 p.m. UTC, <b>Andreas Kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yes is it really an icon?</p></pre>
</blockquote>
<p>On February 29th, 2016, 10:54 p.m. UTC, <b>Elvis Angelaccio</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Mmm you're right. Doesn't look like an icon from Breeze:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">closeAction->setIcon(q->style()->standardIcon(QStyle::SP_DialogCloseButton));</code> (from kmessagewidget.cpp)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So it's an icon coming from the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QStyle</code>. I guess you should ask some Plasma guy to have a look...</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What else if not an icon? Anyway it was removed from the dialog - and probably from all message panels as well.</p></pre>
<br />
<p>- Heiko</p>
<br />
<p>On February 1st, 2016, 6:47 p.m. UTC, Elvis Angelaccio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, KDE Usability, Kai Uwe Broulik, Christoph Feck, and David Faure.</div>
<div>By Elvis Angelaccio.</div>
<p style="color: grey;"><i>Updated Feb. 1, 2016, 6:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Currently a KNewPasswordDialog makes use of a KTitleWidget to display messages to the user about the password status (e.g. "password too short", etc.). This looks out of place, and so does the associated icon (see screenshots in RR 125619: https://git.reviewboard.kde.org/r/125619/ )</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch replaces the KTitleWidget with a KMessageWidget. I also "downgraded" some of the previous "error" red icons to a <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KMessageWidget::Warning</code> type (the orange one in the screenshots), because those kind of messages may be displayed before the user even started typing something as password.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The KMessageWidgets behaves exactly like the KTitleWidget before: initially is hidden, then is displayed as soon as the user interacts with the password fields.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/knewpassworddialog.cpp <span style="color: grey">(1d7ca33ac010a2a1d0971a152d0bef23f78c414d)</span></li>
<li>src/knewpassworddialog.ui <span style="color: grey">(2b492d2a2984296105959d366a1d5306c80af54f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126523/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/f4870422-d064-4da9-b216-056fe5bec665__pwd-dialog-1.png">pwd-dialog-1.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3d8b6c2c-6717-4608-b61c-18ef9b224706__pwd-dialog-2.png">pwd-dialog-2.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/26/3a71ff56-f540-405a-9f3e-868e8d652687__pwd-dialog-3.png">pwd-dialog-3.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>