<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127154/">https://git.reviewboard.kde.org/r/127154/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It seems weird to have a setting for FTP on one side, and a setting for "SMB and SFTP and any slave where this is implemented in the future".
I understand that it was the path of least code changes, but I fear this creates an inconsistency which will lead to more bug reports down the line.
Either we should just have the global option, or it should be per protocol.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can you tell me more about your use case for this option, so we can understand better the reason for all this?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In general I find that .part is good, it 1) tells me that the file isn't ready to be used yet, 2) enables the resuming feature in case the connection drops.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I can very well imagine that some servers disable renaming and then the feature breaks the upload in the first place. Is this is the issue here?
But then it's not even per-protocol, it's per-protocol-and-host.... which might lead to an overblown configuration dialog. But the alternative is for the user to turn off some global setting (like the one you just added) and then (forget to) turn it back on. Right? :-)</p></pre>
<br />
<p>- David Faure</p>
<br />
<p>On February 24th, 2016, 11:52 p.m. UTC, Martin Kostolný wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Edmundson, David Faure, and Marco Martin.</div>
<div>By Martin Kostolný.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2016, 11:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We have an option called "Mark partially uploaded files" in System Settings -> Network: Settings -> Connection Preferences -> FTP Options. This one toggles adding ".part" extension to partially transferred files through FTP protocol.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Other KIO slaves (such as SMB, SFTP) has already working code that supports MarkPartial property read from kioslaverc. This patch is just exposing the property from GUI, specifically I've created "Global Options" section (with one checkbox) above existing "FTP Options" section.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Originally I've created a bug report for this: https://bugs.kde.org/show_bug.cgi?id=359636</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested toggling MarkPartial on SMB, SFTP slaves.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">FISH slave was and still is ignoring it (no .part extension).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I didn't test NFS and others.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kcms/kio/kioslave.kcfg <span style="color: grey">(d34b691)</span></li>
<li>src/kcms/kio/netpref.h <span style="color: grey">(f7a0abc)</span></li>
<li>src/kcms/kio/netpref.cpp <span style="color: grey">(24273a3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127154/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>