<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125987/">https://git.reviewboard.kde.org/r/125987/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 24th, 2016, 8:29 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">should we also add this change to plasma-integration?</p></pre>
</blockquote>
<p>On February 24th, 2016, 8:56 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Indeed, I have the same unittest failure there.
-asterix- dfaure 9:55 /s/kde/build/5/kde/workspace/plasma-integration/autotests>./kfontsettingsdata_unittest
********* Start testing of KFontSettingsData_UnitTest *********
Config: Using QtTest library 5.6.0, Qt 5.6.0 (x86_64-little_endian-lp64 shared (dynamic) debug build; by GCC 4.8.3 20140627 [gcc-4_8-branch revision 212064])
PASS : KFontSettingsData_UnitTest::initTestCase()
PASS : KFontSettingsData_UnitTest::_q_showIfNotHidden()
PASS : KFontSettingsData_UnitTest::testFonts()
QWARN : KFontSettingsData_UnitTest::testFontsChanged() kfontsettingsdata_unittest(11964)/default KIconTheme::KIconTheme: Icon theme "non-existent-icon-theme" not found.
FAIL! : KFontSettingsData_UnitTest::testFontsChanged() Compared values are not the same
Actual (m_fonts->font(KFontSettingsData::GeneralFont)->family()): "OxyFontTest"
Expected (QStringLiteral("ChangedFontTest")) : "ChangedFontTest"
Loc: [/d/kde/src/5/kde/workspace/plasma-integration/autotests/kfontsettingsdata_unittest.cpp(107)]
PASS : KFontSettingsData_UnitTest::cleanupTestCase()
Totals: 4 passed, 1 failed, 0 skipped, 0 blacklisted
********* Finished testing of KFontSettingsData_UnitTest *********
Can you forwardport? (otherwise I'll do it tonight)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Done now. http://commits.kde.org/plasma-integration/36bc1c1ee0ef09adaff31dc95d998f7a04544ceb</p></pre>
<br />
<p>- David</p>
<br />
<p>On February 24th, 2016, 8:05 a.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Àlex Fiestas.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2016, 8:05 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KFontSettingsData autotest: dbus connect happens with QueuedConnection, wait for it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This fixes ./kfontsettingsdata_unittest on my machine. I'm not sure how it passes on CI at all...</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kfontsettingsdata_unittest.cpp <span style="color: grey">(56ba9458625e2f39622251467ee39b388fc6508d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125987/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>