<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127033/">https://git.reviewboard.kde.org/r/127033/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127033/diff/1/?file=443963#file443963line40" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/hunspell/hunspelldict.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">dic</span> <span class="o">=</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="n">dirPath</span><span class="p">)</span> <span class="o">%</span> <span class="n">lang</span> <span class="o">%</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="s">".dic"</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">40</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">dic</span> <span class="o">=</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="n">dirPath</span><span class="p">)</span> <span class="o">%</span> <span class="n">lang</span> <span class="o">%</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="s">".dic"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The QLatin1String here looks wrong, this should be QFile::decodeName().</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127033/diff/1/?file=443963#file443963line42" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/hunspell/hunspelldict.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">QFileInfo</span><span class="p">(</span><span class="n">dic</span><span class="p">).</span><span class="n">exists</span><span class="p">())</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if (!QFileInfo::exists(dic)) is faster</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127033/diff/1/?file=443963#file443963line44" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/hunspell/hunspelldict.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">dic</span> <span class="o">=</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"%1/../share/hunspell/%2.dic"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">QCoreApplication</span><span class="o">::</span><span class="n">applicationDirPath</span><span class="p">(),</span> <span class="n">lang</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And then this could be the same as line 40, both would then be:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #008000; font-weight: bold">dic</span> <span style="color: #666666">=</span> <span style="color: #008000; font-weight: bold">QFile</span><span style="color: #666666">:</span><span style="color: #AA22FF">:decodeName</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">dirPath</span><span style="color: #666666">)</span> <span style="color: #666666">+</span> <span style="color: #008000; font-weight: bold">lang</span> <span style="color: #666666">+</span> <span style="color: #008000; font-weight: bold">QStringLiteral</span><span style="color: #666666">(</span><span style="color: #BA2121">".dic"</span><span style="color: #666666">);</span>
</pre></div>
</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127033/diff/1/?file=443963#file443963line55" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/hunspell/hunspelldict.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">49</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">dic</span> <span class="o">=</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="n">dirPath</span><span class="p">)</span> <span class="o">%</span> <span class="n">QLatin1Char</span><span class="p">(</span><span class="sc">'/'</span><span class="p">)</span> <span class="o">%</span> <span class="n">lang</span> <span class="o">%</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="s">".dic"</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">55</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">dic</span> <span class="o">=</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="n">dirPath</span><span class="p">)</span> <span class="o">%</span> <span class="n">QLatin1Char</span><span class="p">(</span><span class="sc">'/'</span><span class="p">)</span> <span class="o">%</span> <span class="n">lang</span> <span class="o">%</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="s">".dic"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've seen this before.... maybe it should be a function ;)</p></pre>
</div>
</div>
<br />
<p>- David Faure</p>
<br />
<p>On February 10th, 2016, 6:45 p.m. UTC, Kåre Särs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Laurent Montel and Martin Tobias Holmedahl Sandsmark.</div>
<div>By Kåre Särs.</div>
<p style="color: grey;"><i>Updated Feb. 10, 2016, 6:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
sonnet
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The default search path for hunspell dictionaries is /usr/share/hunspell/, but that is not a very common directory on windows ;)
For Windows and Mac there are some extra search paths defined in side #ifdefs, but they are hardcoded to the LibreOffice dictionary directories. Unfortunately the extra Windows path points to a 32bit LibreOffice 5 on a 64 bit Windows directory. This patch adds <app dir>/../share/hunspell/ to the search path in case the default is not found.
If wanted I can add a CMake define for specifying the path relative to the application directory.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled Sonnet and Kate on Windows and got spelling to work :)
It is now possible to add dictionaries to a relocatable <App dir>/../share/hunspell/ and get spelling to work without depending on LibreOffice installation on Windows.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/guesslanguage.cpp <span style="color: grey">(e8deb90)</span></li>
<li>src/plugins/hunspell/hunspellclient.cpp <span style="color: grey">(3da7219)</span></li>
<li>src/plugins/hunspell/hunspelldict.cpp <span style="color: grey">(bc5c314)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127033/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>