<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126774/">https://git.reviewboard.kde.org/r/126774/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 21st, 2016, 4:52 a.m. UTC, <b>Nick Shaforostoff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126774/diff/4/?file=434871#file434871line940" style="color: black; font-weight: bold; text-decoration: underline;">src/core/kprotocolmanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">939</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">info</span> <span class="o">+=</span> <span class="n">Q<span class="hl">L1S</span></span><span class="p">(</span><span class="s">"KDE/"</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">940</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">info</span> <span class="o">+=</span> <span class="n">Q<span class="hl">StringLiteral</span></span><span class="p">(</span><span class="s">"KDE/"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">please revert back to QLatin1String, as there is a special overload for it. if you really want to reduce number of [re]allocs then change it to one big assignment:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">info += ... + ... + ... + ...;</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and make sure QT_USE_STRINGBUILDER is defined</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes there is an overload, but unlike startsWith/endsWith where it's just a comparison, here a conversion to 16 bit will have to happen, in order to append. So a 16 bit literal seems better.</p></pre>
<br />
<p>- David</p>
<br />
<p>On February 20th, 2016, 8:41 p.m. UTC, Russell Greene wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Aleix Pol Gonzalez.</div>
<div>By Russell Greene.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2016, 8:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix many warnings presented by clazy</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I ran the clazy static anaylizer on the codebase and fixed many of the errors.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Many of these were using QStringLiteral instead of QString, which removes an allocation, including Q_OBJECT macros, adding const ref instad of const lvalue, stuff like that.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I ran the entire test suite with the exact same results as master:
Running tests...
Test project /home/russellg/KDE/kio/build
Start 1: testtrash
1/47 Test #1: testtrash ........................................ Passed 1.24 sec
Start 2: kpasswdservertest
2/47 Test #2: kpasswdservertest ................................ Passed 0.73 sec
Start 3: kiocore-kacltest
3/47 Test #3: kiocore-kacltest .................................***Failed 0.04 sec
Start 4: kiocore-listdirtest
4/47 Test #4: kiocore-listdirtest .............................. Passed 0.18 sec
Start 5: kiocore-kmountpointtest
5/47 Test #5: kiocore-kmountpointtest .......................... Passed 0.04 sec
Start 6: kiocore-upurltest
6/47 Test #6: kiocore-upurltest ................................ Passed 0.04 sec
Start 7: kiocore-dataprotocoltest
7/47 Test #7: kiocore-dataprotocoltest ......................... Passed 0.04 sec
Start 8: kiocore-jobtest
8/47 Test #8: kiocore-jobtest ..................................***Exception: Other 0.45 sec
Start 9: kiocore-jobremotetest
9/47 Test #9: kiocore-jobremotetest ............................ Passed 0.11 sec
Start 10: kiocore-kfileitemtest
10/47 Test #10: kiocore-kfileitemtest ............................ Passed 0.08 sec
Start 11: kiocore-kprotocolinfotest
11/47 Test #11: kiocore-kprotocolinfotest ........................ Passed 0.10 sec
Start 12: kiocore-ktcpsockettest
12/47 Test #12: kiocore-ktcpsockettest ........................... Passed 5.28 sec
Start 13: kiocore-globaltest
13/47 Test #13: kiocore-globaltest ............................... Passed 0.04 sec
Start 14: kiocore-mkpathjobtest
14/47 Test #14: kiocore-mkpathjobtest ............................ Passed 0.11 sec
Start 15: kiocore-threadtest
15/47 Test #15: kiocore-threadtest ............................... Passed 0.33 sec
Start 16: kiocore-udsentrytest
16/47 Test #16: kiocore-udsentrytest ............................. Passed 0.04 sec
Start 17: kiocore-udsentry_benchmark
17/47 Test #17: kiocore-udsentry_benchmark ....................... Passed 3.42 sec
Start 18: kiocore-deletejobtest
18/47 Test #18: kiocore-deletejobtest ............................ Passed 0.15 sec
Start 19: kiocore-klocalsockettest
19/47 Test #19: kiocore-klocalsockettest ......................... Passed 0.35 sec
Start 20: kiocore-klocalsocketservertest
20/47 Test #20: kiocore-klocalsocketservertest ................... Passed 0.65 sec
Start 21: kiowidgets-clipboardupdatertest
21/47 Test #21: kiowidgets-clipboardupdatertest .................. Passed 0.43 sec
Start 22: kiowidgets-dropjobtest
22/47 Test #22: kiowidgets-dropjobtest ........................... Passed 4.01 sec
Start 23: kiowidgets-krununittest
23/47 Test #23: kiowidgets-krununittest .......................... Passed 0.69 sec
Start 24: kiowidgets-kdirlistertest
24/47 Test #24: kiowidgets-kdirlistertest ........................ Passed 18.53 sec
Start 25: kiowidgets-kdirmodeltest
25/47 Test #25: kiowidgets-kdirmodeltest ......................... Passed 12.74 sec
Start 26: kiowidgets-kfileitemactionstest
26/47 Test #26: kiowidgets-kfileitemactionstest .................. Passed 0.33 sec
Start 27: kiowidgets-fileundomanagertest
27/47 Test #27: kiowidgets-fileundomanagertest ................... Passed 2.43 sec
Start 28: kiowidgets-kurifiltertest
28/47 Test #28: kiowidgets-kurifiltertest ........................ Passed 6.34 sec
Start 29: kiowidgets-kurlcompletiontest
29/47 Test #29: kiowidgets-kurlcompletiontest .................... Passed 0.32 sec
Start 30: kiowidgets-kurlrequestertest
30/47 Test #30: kiowidgets-kurlrequestertest ..................... Passed 0.35 sec
Start 31: kiowidgets-jobguitest
31/47 Test #31: kiowidgets-jobguitest ............................ Passed 0.66 sec
Start 32: kiowidgets-pastetest
32/47 Test #32: kiowidgets-pastetest ............................. Passed 0.69 sec
Start 33: kiowidgets-accessmanagertest
33/47 Test #33: kiowidgets-accessmanagertest ..................... Passed 0.41 sec
Start 34: kiowidgets-kurifiltersearchprovideractionstest
34/47 Test #34: kiowidgets-kurifiltersearchprovideractionstest ... Passed 0.35 sec
Start 35: kiowidgets-accessmanagertest-qnam
35/47 Test #35: kiowidgets-accessmanagertest-qnam ................ Passed 0.34 sec
Start 36: kiofilewidgets-kurlnavigatortest
36/47 Test #36: kiofilewidgets-kurlnavigatortest ................. Passed 0.44 sec
Start 37: kiofilewidgets-kurlcomboboxtest
37/47 Test #37: kiofilewidgets-kurlcomboboxtest .................. Passed 0.33 sec
Start 38: kiofilewidgets-kdiroperatortest
38/47 Test #38: kiofilewidgets-kdiroperatortest .................. Passed 1.63 sec
Start 39: kiofilewidgets-knewfilemenutest
39/47 Test #39: kiofilewidgets-knewfilemenutest .................. Passed 0.95 sec
Start 40: kiofilewidgets-kfilecopytomenutest
40/47 Test #40: kiofilewidgets-kfilecopytomenutest ............... Passed 0.71 sec
Start 41: kiofilewidgets-kfileplacesmodeltest
41/47 Test #41: kiofilewidgets-kfileplacesmodeltest .............. Passed 0.47 sec
Start 42: kioslave-httpheadertokenizetest
42/47 Test #42: kioslave-httpheadertokenizetest .................. Passed 0.25 sec
Start 43: kioslave-httpheaderdispositiontest
43/47 Test #43: kioslave-httpheaderdispositiontest ...............***Failed 0.25 sec
Start 44: kioslave-httpauthenticationtest
44/47 Test #44: kioslave-httpauthenticationtest .................. Passed 0.25 sec
Start 45: kioslave-httpobjecttest
45/47 Test #45: kioslave-httpobjecttest .......................... Passed 0.26 sec
Start 46: httpfiltertest
46/47 Test #46: httpfiltertest ................................... Passed 0.01 sec
Start 47: kioslave-kcookiejartest
47/47 Test #47: kioslave-kcookiejartest .......................... Passed 0.30 sec
94% tests passed, 3 tests failed out of 47
Total Test time (real) = 67.92 sec
The following tests FAILED:
3 - kiocore-kacltest (Failed)
8 - kiocore-jobtest (OTHER_FAULT)
43 - kioslave-httpheaderdispositiontest (Failed)
Errors while running CTest
Makefile:106: recipe for target 'test' failed
make: *** [test] Error 8</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/http/httpheaderdispositiontest.cpp <span style="color: grey">(ac41656)</span></li>
<li>autotests/http/httpheadertokenizetest.cpp <span style="color: grey">(e57be09)</span></li>
<li>autotests/jobtest.cpp <span style="color: grey">(dfbfba9)</span></li>
<li>autotests/kacltest.cpp <span style="color: grey">(2b88906)</span></li>
<li>autotests/kcookiejar/kcookiejartest.cpp <span style="color: grey">(dab6987)</span></li>
<li>autotests/kfileitemtest.cpp <span style="color: grey">(49d11e1)</span></li>
<li>autotests/kfileplacesmodeltest.cpp <span style="color: grey">(effc95b)</span></li>
<li>autotests/klocalsocketservertest.cpp <span style="color: grey">(9b7f246)</span></li>
<li>autotests/klocalsockettest.cpp <span style="color: grey">(0d831f2)</span></li>
<li>autotests/kmountpointtest.cpp <span style="color: grey">(f6eccd8)</span></li>
<li>autotests/knewfilemenutest.cpp <span style="color: grey">(1b11f15)</span></li>
<li>autotests/kprotocolinfotest.cpp <span style="color: grey">(812f7f7)</span></li>
<li>autotests/ktcpsockettest.cpp <span style="color: grey">(640d871)</span></li>
<li>autotests/kurlnavigatortest.cpp <span style="color: grey">(1b295c3)</span></li>
<li>autotests/udsentry_benchmark.cpp <span style="color: grey">(16c8b7e)</span></li>
<li>src/core/dataprotocol_p.h <span style="color: grey">(784226b)</span></li>
<li>src/core/global.cpp <span style="color: grey">(eaa4264)</span></li>
<li>src/core/job_error.cpp <span style="color: grey">(7943cb3)</span></li>
<li>src/core/kprotocolinfofactory.cpp <span style="color: grey">(1329b6b)</span></li>
<li>src/core/kprotocolmanager.cpp <span style="color: grey">(bd42c9e)</span></li>
<li>src/core/ksambasharedata.cpp <span style="color: grey">(b63f518)</span></li>
<li>src/core/ksslcertificatemanager.cpp <span style="color: grey">(07feda4)</span></li>
<li>src/core/restorejob.cpp <span style="color: grey">(ee5cca9)</span></li>
<li>src/core/sessiondata.cpp <span style="color: grey">(d21ab21)</span></li>
<li>src/core/simplejob.cpp <span style="color: grey">(440fa62)</span></li>
<li>src/core/slave.cpp <span style="color: grey">(5ae4d97)</span></li>
<li>src/core/slavebase.cpp <span style="color: grey">(a9bf648)</span></li>
<li>src/core/statjob.cpp <span style="color: grey">(e55e3b4)</span></li>
<li>src/core/storedtransferjob.cpp <span style="color: grey">(3e86cb9)</span></li>
<li>src/core/tcpslavebase.cpp <span style="color: grey">(2bd1c0f)</span></li>
<li>src/filewidgets/defaults-kfile.h <span style="color: grey">(825a297)</span></li>
<li>src/filewidgets/defaultviewadapter_p.h <span style="color: grey">(79381e4)</span></li>
<li>src/filewidgets/kdiroperator.cpp <span style="color: grey">(9c2b6be)</span></li>
<li>src/filewidgets/kfilecopytomenu.cpp <span style="color: grey">(dab5db6)</span></li>
<li>src/filewidgets/kfileplacesitem.cpp <span style="color: grey">(1748188)</span></li>
<li>src/filewidgets/kfileplacesmodel.cpp <span style="color: grey">(e9d37a9)</span></li>
<li>src/filewidgets/kfileplacesview.cpp <span style="color: grey">(4121191)</span></li>
<li>src/filewidgets/knewfilemenu.cpp <span style="color: grey">(b249898)</span></li>
<li>src/filewidgets/kurlnavigator.cpp <span style="color: grey">(64d2a6d)</span></li>
<li>src/ioslaves/ftp/ftp.cpp <span style="color: grey">(7477a6a)</span></li>
<li>src/ioslaves/http/http.cpp <span style="color: grey">(76da711)</span></li>
<li>src/ioslaves/http/kcookiejar/kcookiejar.cpp <span style="color: grey">(c06882a)</span></li>
<li>src/ioslaves/http/kcookiejar/kcookieserver.cpp <span style="color: grey">(3e7dd8c)</span></li>
<li>src/ioslaves/trash/kcmtrash.cpp <span style="color: grey">(79c2ca7)</span></li>
<li>src/ioslaves/trash/ktrash.cpp <span style="color: grey">(298a201)</span></li>
<li>src/ioslaves/trash/tests/testtrash.cpp <span style="color: grey">(339aa19)</span></li>
<li>src/ioslaves/trash/trashimpl.cpp <span style="color: grey">(26d9ea8)</span></li>
<li>src/kcms/kio/kcookiespolicyselectiondlg.cpp <span style="color: grey">(fcd0763)</span></li>
<li>src/kcms/kio/kproxydlg.cpp <span style="color: grey">(fe2583e)</span></li>
<li>src/kcms/kio/main.cpp <span style="color: grey">(387cf89)</span></li>
<li>src/kcms/kio/useragentdlg.cpp <span style="color: grey">(a6560b5)</span></li>
<li>src/kcms/kio/useragentinfo.cpp <span style="color: grey">(1459fcc)</span></li>
<li>src/kcms/kio/useragentselectordlg.cpp <span style="color: grey">(3952761)</span></li>
<li>src/kioexec/main.cpp <span style="color: grey">(6f4540f)</span></li>
<li>src/kntlm/kntlm.cpp <span style="color: grey">(ed6f388)</span></li>
<li>src/kpac/script.cpp <span style="color: grey">(9b126ca)</span></li>
<li>src/kpasswdserver/kpasswdserver.cpp <span style="color: grey">(7a53300)</span></li>
<li>src/kssld/kssld.cpp <span style="color: grey">(fcc3bed)</span></li>
<li>src/protocoltojson/main.cpp <span style="color: grey">(05b9364)</span></li>
<li>src/urifilters/ikws/kuriikwsfiltereng.h <span style="color: grey">(c8fbcd2)</span></li>
<li>src/urifilters/ikws/searchprovider.cpp <span style="color: grey">(8652997)</span></li>
<li>src/urifilters/ikws/searchproviderdlg.cpp <span style="color: grey">(4effe08)</span></li>
<li>src/urifilters/localdomain/localdomainurifilter.cpp <span style="color: grey">(4ebd1c0)</span></li>
<li>src/urifilters/shorturi/kshorturifilter.cpp <span style="color: grey">(c9024b0)</span></li>
<li>src/widgets/accessmanager.cpp <span style="color: grey">(68f4a27)</span></li>
<li>src/widgets/accessmanagerreply_p.cpp <span style="color: grey">(2ade6fd)</span></li>
<li>src/widgets/delegateanimationhandler.cpp <span style="color: grey">(8e08a0c)</span></li>
<li>src/widgets/fileundomanager.cpp <span style="color: grey">(c9790ab)</span></li>
<li>src/widgets/kbuildsycocaprogressdialog.cpp <span style="color: grey">(9ee0644)</span></li>
<li>src/widgets/kfileitemactions.cpp <span style="color: grey">(4343da7)</span></li>
<li>src/widgets/kopenwithdialog.cpp <span style="color: grey">(808af73)</span></li>
<li>src/widgets/kpropertiesdialog.cpp <span style="color: grey">(a4fdeb9)</span></li>
<li>src/widgets/krun.cpp <span style="color: grey">(af48473)</span></li>
<li>src/widgets/kurlcompletion.cpp <span style="color: grey">(7160491)</span></li>
<li>src/widgets/kurlrequester.cpp <span style="color: grey">(06e9ddb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126774/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>