<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127121/">https://git.reviewboard.kde.org/r/127121/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 20th, 2016, 8:25 p.m. UTC, <b>Andreas Hartmetz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry for being the guy who says "I don't like this improvement because it's still not perfect"...
Why have a timeout at all and not, for example, retry after getting a timeout error? (A long timeout still makes sense to avoid most UI glitches)
I hope nobody uses the synchronous API in the UI thread, it would be a terrible idea to do that anyway. Is this for e.g. Akonadi agents? Those could as well wait indefinitely. If they can't -> well they shouldn't use synchronous API. Synchronous IPC to an unreliable peer (if the user is involved it's unreliable ;) is asking for problems.</p></pre>
</blockquote>
<p>On February 20th, 2016, 8:31 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi Andreas, thanks for your input. (I would also welcome your input on https://git.reviewboard.kde.org/r/127077/ even though I just pushed it).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The use cases I saw (where the timeout was a problem with a sync call) are ksshaskpass (no GUI yet at that point) and the imap resource. So yes, infinite wait would be good, I agree. I just don't know how big a number DBus supports for a timeout. Shall we make it 2^31-1 to avoid any signedness issues? I'm not going to actually test if it can wait that long though ;)</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Some very large number would be fine. If something has a problem with an extremely long timeout it will have the same problem with an hour-long timeout. And if that something has a problem with it, that is its own fault.
Sorry about the other one, I noticed it too late. I can still have a look.</p></pre>
<br />
<p>- Andreas</p>
<br />
<p>On February 20th, 2016, 2:16 p.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Valentin Rusu.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2016, 2:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwallet
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The default DBus timeout is 25 seconds, which means that if the user went to
get a cup of tea during session startup, when they come back they get prompted
with all sorts of additional non-kwallet password requests due to all kwallet
requests having timed out.
I added setTimeout in QDBusAbstractInterface in Qt 4.8 for things like this.
Testcase:
eval `dbus-launch`
export SSH_ASKPASS=$KDEDIR/bin/ksshaskpass
ssh-add < /dev/null
(but the same happens with the IMAP resource etc.)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(see commit log)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/api/KWallet/kwallet.cpp <span style="color: grey">(b72edad19840943f70755c8668668a1881f1fb39)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127121/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>