<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126675/">https://git.reviewboard.kde.org/r/126675/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126675/diff/2/?file=441771#file441771line22" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">22</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">find_package(KF5Archive REQUIRED NO_MODULE)</pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What about making this optional (and only building those two plugins if it is found)?</p></pre>
</div>
</div>
<br />
<p>- Alex Merry</p>
<br />
<p>On January 27th, 2016, 9:48 a.m. UTC, Boudewijn Rempt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Alex Merry.</div>
<div>By Boudewijn Rempt.</div>
<p style="color: grey;"><i>Updated Jan. 27, 2016, 9:48 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kimageformats
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">These qimageio plugins originally come from krita, but people who haven't got krita installed might want to view Krita or OpenRaster images as well. Both formats are really simple, just zip files with a png inside that represents the merged image. This patch does add a KF5::Archive dependency to kimageformats.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(1e7e703)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(853607e)</span></li>
<li>autotests/read/kra/src.kra <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/kra/src.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/ora/src.ora <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/ora/src.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imageformats/CMakeLists.txt <span style="color: grey">(8cf8d54)</span></li>
<li>src/imageformats/kra.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imageformats/kra.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imageformats/kra.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imageformats/kra.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imageformats/ora.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imageformats/ora.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imageformats/ora.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imageformats/ora.json <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126675/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>