<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126887/">https://git.reviewboard.kde.org/r/126887/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- David Faure</p>
<br />
<p>On January 26th, 2016, 8:30 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Jan. 26, 2016, 8:30 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">NETRootInfo can be used without requiring a QCoreApplication. But there
are calls into KWindowSytem to check whether viewports are used. This
creates a static container and tries to move it to the main thread of
the QCoreApplication. If we don't have a QCoreApplication this crashes.
This change ensures that it's possible to call into mapViewport even
if there is no QCoreApplication. It will return false as also no plugin
will be loadable.
The change comes with a new auto test which simulates the condition
of calling into mapViewport without a QCoreApplication.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(bf83d1446348aa1985f0c27275ae8b3013b86dbd)</span></li>
<li>autotests/dontcrashmapviewport.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/netrootinfotestwm.cpp <span style="color: grey">(d0be10690a5ec099549b9eeae6cdea4100d13949)</span></li>
<li>src/kwindowsystem.cpp <span style="color: grey">(9ef273f7679f34e7c9f986b55e39e4f8420490c1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126887/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>