<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126857/">https://git.reviewboard.kde.org/r/126857/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- David Edmundson</p>
<br />
<p>On January 23rd, 2016, 9:47 p.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Jan. 23, 2016, 9:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">CacheLocation was used instead of GenericCacheLocation, so the appname was inserted
into it which would have broken sharing the cache between apps. But anyway no
caching happened at all because the subdir of the cache wasn't being created
(missing mkpath).
Repairing the use of the cache brought up an assert just after writing, because
the size of cache entries wasn't the expected size; this was due to mtime -> QDateTime
porting. Repaired by converting to "seconds since epoch", like kdelibs4 was doing.
Milliseconds don't seem to be part of the RFCs for HTTP dates anyway.
Change-Id: Ie13c9923f02429a8b1893ba9f66f733673d5ddad</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I spotted the error below in kio_http's output
HTTPProtocol::cacheFileOpenWrite: Could not open file for writing: "" due to error 5</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(First fix was to fix the debug output not to show an empty filename on error)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now kio_http says lots of good things like "readBody: reading data from cache..."</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/kprotocolmanager.cpp <span style="color: grey">(bd42c9e1bb6379238a46c6483f12bcbc9ccc0e6d)</span></li>
<li>src/core/sessiondata.cpp <span style="color: grey">(d21ab21581da3f5bf3dc31c012d0056f50af3423)</span></li>
<li>src/ioslaves/http/http.cpp <span style="color: grey">(76da711cbb3eee9ba801a6e8117d78aaee467626)</span></li>
<li>src/ioslaves/http/http_cache_cleaner.cpp <span style="color: grey">(c272c6ecc75ef07418cdfe4a17af4b0475d6ff0a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126857/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>