<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126798/">https://git.reviewboard.kde.org/r/126798/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please remove the commented qDebugs as well</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126798/diff/1/?file=434224#file434224line123" style="color: black; font-weight: bold; text-decoration: underline;">src/core/engine.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">122</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">m_installation</span><span class="o">-></span><span class="n">readConfig</span><span class="p">(</span><span class="n">group</span><span class="p">))</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">123</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">bool</span> <span class="n">default_installation</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Initialize with declaration</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126798/diff/1/?file=434224#file434224line135" style="color: black; font-weight: bold; text-decoration: underline;">src/core/engine.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">135</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="nb">false</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Shouldn't this break? Otherwise some of the installations won't get connected.</p></pre>
</div>
</div>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On January 18th, 2016, 5:27 p.m. CET, Demitrius Belai wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Jeremy Whiting.</div>
<div>By Demitrius Belai.</div>
<p style="color: grey;"><i>Updated Jan. 18, 2016, 5:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knewstuff
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This allow to configure installation method per categorie. For example, kwin aurorae.knsrc</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #008000; font-weight: bold">[KNewStuff3]</span>
<span style="color: #7D9029">ProvidersUrl</span><span style="color: #666666">=</span><span style="color: #BA2121">http://download.kde.org/ocs/providers.xml</span>
<span style="color: #7D9029">Categories</span><span style="color: #666666">=</span><span style="color: #BA2121">Window Decoration Aurorae,KWin Decoration QtQuick</span>
<span style="color: #7D9029">Uncompress</span><span style="color: #666666">=</span><span style="color: #BA2121">archive</span>
<span style="color: #7D9029">TargetDir</span><span style="color: #666666">=</span><span style="color: #BA2121">aurorae/themes</span>
<span style="color: #008000; font-weight: bold">[KWin Decoration QtQuick]</span>
<span style="color: #7D9029">StandardResource</span><span style="color: #666666">=</span><span style="color: #BA2121">tmp</span>
<span style="color: #7D9029">InstallationCommand</span><span style="color: #666666">=</span><span style="color: #BA2121">plasmapkg2 -t kwindecoration -i %f</span>
<span style="color: #7D9029">UninstallCommand</span><span style="color: #666666">=</span><span style="color: #BA2121">plasmapkg2 -t kwindecoration -r %f</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This don't break backward. Category which don't have group in config will be installed by default installation method in [KNewStuff3] group.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/attica/atticaprovider.cpp <span style="color: grey">(07508b05f324f25481bf05c5717c0ca60dce70d1)</span></li>
<li>src/core/engine.cpp <span style="color: grey">(c8d0579eed8592c0c210ad61cbd5cbf4add53f95)</span></li>
<li>src/core/engine_p.h <span style="color: grey">(11571bfcd030ed2832ae64781323494365837296)</span></li>
<li>src/core/entryinternal.cpp <span style="color: grey">(b05fe24417554b78fc206d3437e4d11ef2eefcb7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126798/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>