<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126770/">https://git.reviewboard.kde.org/r/126770/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Makes sense, +1.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126770/diff/1/?file=431663#file431663line152" style="color: black; font-weight: bold; text-decoration: underline;">src/ksendbugmail/main.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">152</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">sm</span><span class="o">-></span><span class="n">setMessageHeader</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"From: %1</span><span class="se">\r\n</span><span class="s">To: %2</span><span class="se">\r\n</span><span class="s">"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">fromaddr</span><span class="p"><span class="hl">).</span></span><span class="n"><span class="hl">arg</span></span><span class="p"><span class="hl">(</span></span><span class="n">QString</span><span class="p">(</span><span class="n">recipient</span><span class="p">)));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">152</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">sm</span><span class="o">-></span><span class="n">setMessageHeader</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"From: %1</span><span class="se">\r\n</span><span class="s">To: %2</span><span class="se">\r\n</span><span class="s">"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">fromaddr</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n">QString</span><span class="p">(</span><span class="n">recipient</span><span class="p">)));</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">recipient seems to already be a QString, no need to explicitly pass the constructor.</p></pre>
</div>
</div>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On January 16th, 2016, 4:36 p.m. CET, Andrey Cygankov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Aleix Pol Gonzalez.</div>
<div>By Andrey Cygankov.</div>
<p style="color: grey;"><i>Updated Jan. 16, 2016, 4:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kxmlgui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix all Clazy warnings, except:
/src/kaboutapplicationpersonlistdelegate_p.cpp:156:16: warning: Missing reference in foreach with sizeof(T) = 24 bytes (class KDEPrivate::KAboutApplicationPersonProfileOcsLink) [-Wclazy-foreach]
Q_FOREACH (KAboutApplicationPersonProfileOcsLink link, profile.ocsLinks()) {
in kmainwindow_unittest.cpp - Many warnings related to Qt macros, example:
/autotests/kmainwindow_unittest.cpp:162:9: warning: QString::fromUtf8() being passed a literal [-Wclazy-qstring-uneeded-heap-allocations]
QTRY_COMPARE(mw.size(), QSize(800, 600));
^
/usr/include/x86_64-linux-gnu/qt5/QtTest/qtestcase.h:167:42: note: expanded from macro 'QTRY_COMPARE'
#define QTRY_COMPARE(__expr, __expected) QTRY_COMPARE_WITH_TIMEOUT((__expr), __expected, 5000)
^
/usr/include/x86_64-linux-gnu/qt5/QtTest/qtestcase.h:163:5: note: expanded from macro 'QTRY_COMPARE_WITH_TIMEOUT'
QTRY_IMPL(((__expr) == (__expected)), __timeout);\
^
/usr/include/x86_64-linux-gnu/qt5/QtTest/qtestcase.h:149:5: note: expanded from macro 'QTRY_IMPL'
QTRY_TIMEOUT_DEBUG_IMPL((__expr), __timeoutValue, __step)\
^
/usr/include/x86_64-linux-gnu/qt5/QtTest/qtestcase.h:139:27: note: expanded from macro 'QTRY_TIMEOUT_DEBUG_IMPL'
QString msg = QString::fromUtf8("QTestLib: This test case check (\"%1\") failed because the requested timeout (%2 ms) was too short, %3 ms would have been sufficient this time."); \
^</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Build without errors.
Tests passed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kactioncategorytest.cpp <span style="color: grey">(ab561d2)</span></li>
<li>autotests/kactioncollectiontest.cpp <span style="color: grey">(b4aa244)</span></li>
<li>autotests/kmainwindow_unittest.cpp <span style="color: grey">(00282ef)</span></li>
<li>autotests/ktoolbar_unittest.cpp <span style="color: grey">(d6c1e05)</span></li>
<li>autotests/kxmlgui_unittest.cpp <span style="color: grey">(37fd9c3)</span></li>
<li>src/kaboutapplicationdialog.cpp <span style="color: grey">(87af640)</span></li>
<li>src/kbugreport.cpp <span style="color: grey">(f418dde)</span></li>
<li>src/kcheckaccelerators.cpp <span style="color: grey">(85a7d17)</span></li>
<li>src/kedittoolbar.cpp <span style="color: grey">(ba4ba0f)</span></li>
<li>src/kmainwindow.cpp <span style="color: grey">(cae655d)</span></li>
<li>src/kmenumenuhandler_p.cpp <span style="color: grey">(91297a8)</span></li>
<li>src/ksendbugmail/main.cpp <span style="color: grey">(71b8e0e)</span></li>
<li>src/kshortcutseditordelegate.cpp <span style="color: grey">(7b41089)</span></li>
<li>src/ktoolbar.cpp <span style="color: grey">(8fcb9cb)</span></li>
<li>src/kxmlguifactory_p.cpp <span style="color: grey">(5e1a0d6)</span></li>
<li>tests/kwindowtest.cpp <span style="color: grey">(0555a56)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126770/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>