<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126735/">https://git.reviewboard.kde.org/r/126735/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Январь 14th, 2016, 12:07 д.п. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">These look good. You wrote "most". Which warnings couldn't you fix?</p></pre>
</blockquote>
<p>On Январь 14th, 2016, 12:23 д.п. UTC, <b>Andrey Cygankov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">log file sent</p></pre>
</blockquote>
<p>On Январь 14th, 2016, 12:26 д.п. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">/home/andrey/dev/projects/kitemmodels/autotests/proxymodeltestsuite/proxymodeltest.h:762:17: note: expanded from macro 'PROXYMODELTEST_MAIN'</code> << here you need to wrap in QLatin1String().
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">/home/andrey/dev/projects/kitemmodels/tests/proxymodeltestapp/breadcrumbnavigationwidget.cpp:35:43:</code> here you need to use the QStringLiteral.
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">/home/andrey/dev/projects/kitemmodels/tests/proxymodeltestapp/selectioninqmlwidget.cpp:57</code> also here: <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">quickView->setSource(QUrl::fromLocalFile(QStringLiteral(SRC_DIR "/selection.qml")));</code></p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I do not know how to correct the warnings out there that use a function defined by #define.
May be you give an example?</p></pre>
<br />
<p>- Andrey</p>
<br />
<p>On Январь 14th, 2016, 8:52 д.п. UTC, Andrey Cygankov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Aleix Pol Gonzalez.</div>
<div>By Andrey Cygankov.</div>
<p style="color: grey;"><i>Updated Янв. 14, 2016, 8:52 д.п.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kitemmodels
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixed most Clazy warnings in KItemModels.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Build without errors.
Tests passed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kconcatenaterowsproxymodeltest.cpp <span style="color: grey">(0a2f794)</span></li>
<li>autotests/kextracolumnsproxymodeltest.cpp <span style="color: grey">(015ea65)</span></li>
<li>autotests/krearrangecolumnsproxymodeltest.cpp <span style="color: grey">(70e6ea9)</span></li>
<li>autotests/krecursivefilterproxymodeltest.cpp <span style="color: grey">(8c7c65e)</span></li>
<li>autotests/kselectionproxymodeltest.cpp <span style="color: grey">(ac3d324)</span></li>
<li>autotests/proxymodeltestsuite/dynamictreemodel.cpp <span style="color: grey">(d5a12e7)</span></li>
<li>autotests/proxymodeltestsuite/dynamictreewidget.cpp <span style="color: grey">(5a0462b)</span></li>
<li>autotests/proxymodeltestsuite/modelcommander.cpp <span style="color: grey">(8311e5b)</span></li>
<li>autotests/proxymodeltestsuite/modelspy.cpp <span style="color: grey">(bb8e520)</span></li>
<li>autotests/proxymodeltestsuite/proxymodeltest.cpp <span style="color: grey">(dd596c6)</span></li>
<li>src/kconcatenaterowsproxymodel.cpp <span style="color: grey">(074fcd3)</span></li>
<li>src/kselectionproxymodel.cpp <span style="color: grey">(4d7af29)</span></li>
<li>tests/proxymodeltestapp/breadcrumbdirectionwidget.cpp <span style="color: grey">(1e01ae3)</span></li>
<li>tests/proxymodeltestapp/breadcrumbnavigationwidget.cpp <span style="color: grey">(a0493c2)</span></li>
<li>tests/proxymodeltestapp/breadcrumbswidget.cpp <span style="color: grey">(d583856)</span></li>
<li>tests/proxymodeltestapp/checkablewidget.cpp <span style="color: grey">(d51458a)</span></li>
<li>tests/proxymodeltestapp/descendantpmwidget.cpp <span style="color: grey">(39bd062)</span></li>
<li>tests/proxymodeltestapp/kidentityproxymodelwidget.cpp <span style="color: grey">(0150c70)</span></li>
<li>tests/proxymodeltestapp/kreparentingproxymodel.cpp <span style="color: grey">(e79392c)</span></li>
<li>tests/proxymodeltestapp/lessthanwidget.cpp <span style="color: grey">(7af3c1c)</span></li>
<li>tests/proxymodeltestapp/proxyitemselectionwidget.cpp <span style="color: grey">(e075dbf)</span></li>
<li>tests/proxymodeltestapp/reparentingpmwidget.cpp <span style="color: grey">(2593732)</span></li>
<li>tests/proxymodeltestapp/selectionpmwidget.cpp <span style="color: grey">(f5b353a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126735/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>