<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126737/">https://git.reviewboard.kde.org/r/126737/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 14th, 2016, 12:35 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks good, I'll add Sergio, he maybe can explain what the warning meant in the first place.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Andrey, Are you sure you fixed all the warnings? I found some missing, for example:
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">/home/kde-devel/frameworks/kitemviews/src/kwidgetitemdelegatepool.cpp:48:1: warning: KWidgetItemDelegateEventListener is missing a Q_OBJECT macro [-Wclazy-missing-qobject]</code></p></pre>
</blockquote>
<p>On January 14th, 2016, 1:45 p.m. UTC, <b>Andrey Cygankov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Strangely, I had not noticed the warning in the log . I get to the PC - see the log again.</p></pre>
</blockquote>
<p>On January 14th, 2016, 1:57 p.m. UTC, <b>Andrey Cygankov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Some warnings , such as using qstringlitetal to initialize a blank line , I thought it wrong. Article Qt Weekly says that empty lines use the qstringliteral is not effective.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">what do you mean by blank line, and can you link to that Qt weekly article ?</p></pre>
<br />
<p>- Sergio</p>
<br />
<p>On January 14th, 2016, 12:35 p.m. UTC, Andrey Cygankov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins.</div>
<div>By Andrey Cygankov.</div>
<p style="color: grey;"><i>Updated Jan. 14, 2016, 12:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kitemviews
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix Clazy warnings, except:
/src/kwidgetitemdelegatepool.cpp:153:5: warning: Calling qDeleteAll with QHash::keys, call qDeleteAll on the container itself [-Wclazy-qdeleteall]
qDeleteAll(d->widgetInIndex.keys());</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Build without errors.
Tests passed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/klistwidgetsearchlinetest.cpp <span style="color: grey">(b86d62c)</span></li>
<li>src/kcategorizedview.cpp <span style="color: grey">(185c24c)</span></li>
<li>src/ktreewidgetsearchline.cpp <span style="color: grey">(b721c58)</span></li>
<li>tests/kcategorizedviewtest.cpp <span style="color: grey">(16dac9a)</span></li>
<li>tests/ktreewidgetsearchlinetest.cpp <span style="color: grey">(adaf246)</span></li>
<li>tests/kwidgetitemdelegatetest.cpp <span style="color: grey">(d4bba7a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126737/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>