<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126735/">https://git.reviewboard.kde.org/r/126735/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 14th, 2016, 9:47 a.m. CET, <b>Kåre Särs</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126735/diff/2/?file=430620#file430620line47" style="color: black; font-weight: bold; text-decoration: underline;">tests/proxymodeltestapp/proxyitemselectionwidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">ProxyItemSelectionWidget::ProxyItemSelectionWidget(QWidget *parent, Qt::WindowFlags f)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">47</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span><span class="p">(</span><span class="s">"- 1"</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">47</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString<span class="hl">Literal</span></span><span class="p">(</span><span class="s">"- 1"</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QStringLiteral with multiple string initializers does not work on Windows. All places without arguments could use QLatin1String.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There are multiple cases with the same issue in this review. Clazy should be fixed to not suggest this change...</p></pre>
</blockquote>
<p>On January 14th, 2016, 10:54 a.m. CET, <b>Kåre Särs</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 Good to go from my point of view :) I'll let Aleix give the Shipit.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Actually it has, Andrey update your clazy ;).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">commit 04a6c6665e73da087cec7d66039830d2932305f7
Author: Sergio Martins <smartins@kde.org>
Date: Thu Jan 14 10:23:06 2016 +0000
qstring-uneeded-heap-allocations: Rename msvc-compat to no-msvc-compat
Meaning msvc-compat is the default and if you don't want it you should:
export CLAZY_EXTRA_OPTIONS="qstring-uneeded-heap-allocations-no-msvc-compat"
Helps stopping annoying our windows friends.
Ignoring multi-string literals is not implemented yet, only ignoring list initialization.
CCBUG: 357966
</pre></div>
</p></pre>
<br />
<p>- Aleix</p>
<br />
<p>On January 14th, 2016, 9:52 a.m. CET, Andrey Cygankov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Aleix Pol Gonzalez.</div>
<div>By Andrey Cygankov.</div>
<p style="color: grey;"><i>Updated Jan. 14, 2016, 9:52 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kitemmodels
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixed most Clazy warnings in KItemModels.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Build without errors.
Tests passed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kconcatenaterowsproxymodeltest.cpp <span style="color: grey">(0a2f794)</span></li>
<li>autotests/kextracolumnsproxymodeltest.cpp <span style="color: grey">(015ea65)</span></li>
<li>autotests/krearrangecolumnsproxymodeltest.cpp <span style="color: grey">(70e6ea9)</span></li>
<li>autotests/krecursivefilterproxymodeltest.cpp <span style="color: grey">(8c7c65e)</span></li>
<li>autotests/kselectionproxymodeltest.cpp <span style="color: grey">(ac3d324)</span></li>
<li>autotests/proxymodeltestsuite/dynamictreemodel.cpp <span style="color: grey">(d5a12e7)</span></li>
<li>autotests/proxymodeltestsuite/dynamictreewidget.cpp <span style="color: grey">(5a0462b)</span></li>
<li>autotests/proxymodeltestsuite/modelcommander.cpp <span style="color: grey">(8311e5b)</span></li>
<li>autotests/proxymodeltestsuite/modelspy.cpp <span style="color: grey">(bb8e520)</span></li>
<li>autotests/proxymodeltestsuite/proxymodeltest.cpp <span style="color: grey">(dd596c6)</span></li>
<li>src/kconcatenaterowsproxymodel.cpp <span style="color: grey">(074fcd3)</span></li>
<li>src/kselectionproxymodel.cpp <span style="color: grey">(4d7af29)</span></li>
<li>tests/proxymodeltestapp/breadcrumbdirectionwidget.cpp <span style="color: grey">(1e01ae3)</span></li>
<li>tests/proxymodeltestapp/breadcrumbnavigationwidget.cpp <span style="color: grey">(a0493c2)</span></li>
<li>tests/proxymodeltestapp/breadcrumbswidget.cpp <span style="color: grey">(d583856)</span></li>
<li>tests/proxymodeltestapp/checkablewidget.cpp <span style="color: grey">(d51458a)</span></li>
<li>tests/proxymodeltestapp/descendantpmwidget.cpp <span style="color: grey">(39bd062)</span></li>
<li>tests/proxymodeltestapp/kidentityproxymodelwidget.cpp <span style="color: grey">(0150c70)</span></li>
<li>tests/proxymodeltestapp/kreparentingproxymodel.cpp <span style="color: grey">(e79392c)</span></li>
<li>tests/proxymodeltestapp/lessthanwidget.cpp <span style="color: grey">(7af3c1c)</span></li>
<li>tests/proxymodeltestapp/proxyitemselectionwidget.cpp <span style="color: grey">(e075dbf)</span></li>
<li>tests/proxymodeltestapp/reparentingpmwidget.cpp <span style="color: grey">(2593732)</span></li>
<li>tests/proxymodeltestapp/selectionpmwidget.cpp <span style="color: grey">(f5b353a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126735/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>