<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126650/">https://git.reviewboard.kde.org/r/126650/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm interested in the reasoning why to put it into KIdleTime? My first thought would have been Solid, so I'm interested in the reasoning.</p></pre>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On January 6th, 2016, 8:17 a.m. CET, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Kai Uwe Broulik.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Jan. 6, 2016, 8:17 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kidletime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a work-in-progress, but I'm putting it up for a feedback now
as most people are gone for the day when I wake up :)
---
After some discussion in https://git.reviewboard.kde.org/r/126627/
and then with Kai Uwe Broulik, I've added a PM/ScreenSaver inhibition
capabilities to KIdleItem.
We decided with Kai that we want simple stuff, encapsulated away for
the client as much as possible. So the Inhibition class has a static
"constructors" which make the usage as easy as follows:
KIdleTime::Inhibition::createInhibition(KIdleTime::Inhibition::InhibitScreen, QStringLiteral("Playing Movie"), mainWindow);
That call would return an Inhibition* object which has methods to set
the inhibition type and reason and to activate/deactivate the inhibition.
The static method above would activate() on the Inhibition right away;
this allows a simple fire-and-forget usage. The Inhibition object can
be parented to any other object; the inhibition will be deactivated when
the Inhibition object is destroyed. The user can also keep the pointer
around and call deactivate() whenever actually needed.
The inhibition itself first looks for Solid and if present, it uses the
Solid interface. If not present, it goes for the FDO interfaces.
It comes with an autotest.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Everything works as expected, plus there's an autotest.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/qtest_dbus.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(23e5e29)</span></li>
<li>autotests/inhibition_test.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/fakePMServer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/inhibition.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/inhibition.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/fakePMServer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(ed5dc0c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126650/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>